Closed Bug 771489 Opened 8 years ago Closed 8 years ago

use standard threadsafe refcounting in host resolver

Categories

(Core :: Networking: DNS, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jaas, Assigned: jaas)

Details

Attachments

(1 file, 2 obsolete files)

Attached patch fix v1.0 (obsolete) — Splinter Review
We should use standard threadsafe refcounting in the host resolver, not a custom scheme.
Attachment #639635 - Flags: review?(sworkman)
Comment on attachment 639635 [details] [diff] [review]
fix v1.0

Looks good to me. Thanks Josh.
Attachment #639635 - Flags: review?(sworkman) → review+
Attached patch fix v1.1 (obsolete) — Splinter Review
There was some funny business with how the refcount was initialized for host records. This should fix it.
Attachment #639635 - Attachment is obsolete: true
Now tests show we're leaking host records.
Attached patch fix v1.2Splinter Review
The refcounting was fine, nothing was actually leaking, but refcount reporting was bad so the tests thought something was leaking. This is exactly why we need to get on a standardized addref/release scheme.
Attachment #639958 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/7578fa8c76f7
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.