use standard threadsafe refcounting in host resolver

RESOLVED FIXED in mozilla16

Status

()

Core
Networking: DNS
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Josh Aas, Assigned: Josh Aas)

Tracking

Trunk
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

5 years ago
Created attachment 639635 [details] [diff] [review]
fix v1.0

We should use standard threadsafe refcounting in the host resolver, not a custom scheme.
Attachment #639635 - Flags: review?(sworkman)
Comment on attachment 639635 [details] [diff] [review]
fix v1.0

Looks good to me. Thanks Josh.
Attachment #639635 - Flags: review?(sworkman) → review+
(Assignee)

Comment 2

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=01608f6c34f0
(Assignee)

Comment 3

5 years ago
Created attachment 639958 [details] [diff] [review]
fix v1.1

There was some funny business with how the refcount was initialized for host records. This should fix it.
Attachment #639635 - Attachment is obsolete: true
(Assignee)

Comment 4

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=ef29a6f51360
(Assignee)

Comment 5

5 years ago
Now tests show we're leaking host records.
(Assignee)

Comment 6

5 years ago
Created attachment 640322 [details] [diff] [review]
fix v1.2

The refcounting was fine, nothing was actually leaking, but refcount reporting was bad so the tests thought something was leaking. This is exactly why we need to get on a standardized addref/release scheme.
Attachment #639958 - Attachment is obsolete: true
(Assignee)

Comment 7

5 years ago
https://tbpl.mozilla.org/?tree=Try&rev=3b2acb93c0bc
(Assignee)

Comment 8

5 years ago
pushed to mozilla-inbound

http://hg.mozilla.org/integration/mozilla-inbound/rev/7578fa8c76f7
https://hg.mozilla.org/mozilla-central/rev/7578fa8c76f7
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.