Closed Bug 771498 Opened 9 years ago Closed 9 years ago

FileHandle: getFile() should return a DOMRequest (instead of a FileRequest)

Categories

(Core :: DOM: Core & HTML, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16
Tracking Status
firefox13 --- unaffected
firefox14 --- unaffected
firefox15 --- fixed
firefox16 --- fixed
firefox-esr10 --- unaffected

People

(Reporter: janv, Assigned: janv)

References

Details

(Whiteboard: [qa-])

Attachments

(1 file)

No description provided.
Attached patch fixSplinter Review
Assignee: nobody → Jan.Varga
Status: NEW → ASSIGNED
Attachment #639938 - Flags: review?(jonas)
Comment on attachment 639938 [details] [diff] [review]
fix

Review of attachment 639938 [details] [diff] [review]:
-----------------------------------------------------------------

Looks great!
Attachment #639938 - Flags: review?(jonas) → review+
Comment on attachment 639938 [details] [diff] [review]
fix

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 
This is a bug in a new feature

User impact if declined:
There's a risk that developers will misunderstand how this new API is supposed to be used. This has already happened which is how we found this bug. Such misunderstanding will lead to a slower website and probably in the future we'll be foreced to break this behavior, causing websites to break.

Testing completed (on m-c, etc.):
Patch contains mochitest and should land very soon on m-c.

Risk to taking this patch (and alternatives if risky): 
There's very little risk. The patch logic is very simple, and it strictly speaking just removes functionality from websites.

String or UUID changes made by this patch:
Only changes the UUID of APIs which are new for FF15
Attachment #639938 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/5549659290f7
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Comment on attachment 639938 [details] [diff] [review]
fix

[Triage Comment]
New APIs in FF15, so no problem with approving this change. Can you make sure to block the original feature bug on this one? Thanks.
Attachment #639938 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Whiteboard: [qa-]
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.