771500 - IonMonkey: Implement argument setters

Status: RESOLVED DUPLICATE of bug 1478350

(Core :: JavaScript Engine, enhancement, P3)

Description

[Nicolas B. Pierron [:nbp] {back on 17/11}]

As of today this bug is not a priority for benchmarks but a sub-part of it was implemented with Bug 735406.

Argument setter are not yet compiled with IonMonkey because they are multiple case to handle because formal arguments and actual arguments are not handle the same way.

If the actual arguments are never manipulating any of the formal arguments, then there is no issue to handle actual arguments except that we need a new alias kind to order the set/get of the arguments.

If the formal arguments are read/write at the same time, we want to produce a dynamic get/set for each of the formal argument such as the get/set of the formal argument are handled by the alias analysis.

Another way would be to allocate the formal argument at a specific stack slot which correspond to their location in the actual argument vector.

Comment 1

[Nicolas B. Pierron [:nbp] {back on 17/11}]

Attachment: Handle setters on actual arguments.

This patch coming from Bug 735406, made by me, and reviewed by dvander.
https://bugzilla.mozilla.org/attachment.cgi?id=630619 and is waiting for check-in when this bug would be considered as important.

Comment 2

[Matthew Gaudet (he/him) [:mgaudet]]

Hey Iain: Is this already done?

Comment 3

[Iain Ireland [:iain]]

Yeah, this has been done for years. Without digging too much, I think everything was supported no later than bug 1478350.