Closed Bug 771501 Opened 12 years ago Closed 12 years ago

Update text selection handle graphics

Categories

(Firefox for Android Graveyard :: Text Selection, defect)

Product:
Firefox for Android Graveyard
Component:
Text Selection
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox15 verified, firefox16 verified, firefox17 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- verified
firefox16 --- verified
firefox17 --- verified

People

(Reporter: ibarlow, Assigned: Margaret)

References

Details

Attachments

(3 files)

selection handle graphics
24.31 KB, application/x-zip-compressed
Details
patch
6.60 KB, patch
mfinkle
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review
screenshot
269.50 KB, image/png
Details 
Icons attached, and here is a mockup of what they should look like: http://cl.ly/2B0X24133z2B2i1P2H1T
So do we want to use these images on all Android versions?
Assignee: nobody → margaret.leibovic
Yes, please.
Attached patch patch — — Splinter Review 
Because the handle images are used in content, we don't actually need different images for different screen resolutions. I decided to use the images in the hdpi folder, since those were closest in dimension (45x66) to the existing handle images (35x64).
Attachment #639732 - Flags: review?(mark.finkle)
Attached image screenshot — 
Even though we now scale the handles on zoom so that they always stay the same size on a given page, I've noticed that they can be different sizes of different pages, and I'm not sure why that is happening. That's something we should address in a separate bug, though.
Comment on attachment 639732 [details] [diff] [review]
patch

ORANGE!
Attachment #639732 - Flags: review?(mark.finkle) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/edfbf1e2f6b7
OS: Mac OS X → Android
Hardware: x86 → ARM
Target Milestone: --- → Firefox 16
Version: Firefox 15 → Trunk
https://hg.mozilla.org/mozilla-central/rev/edfbf1e2f6b7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment on attachment 639732 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): this should be part of the text selection mass uplift (bug 695173), but was fixed after the roll-up patch in that bug was created
User impact if declined: text selection handles are ugly
Testing completed (on m-c, etc.): landed on m-c 7/7
Risk to taking this patch (and alternatives if risky): low risk image swap 
String or UUID changes made by this patch: n/a
Attachment #639732 - Flags: approval-mozilla-aurora?
Attachment #639732 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Uplifted to aurora as part of a roll-up patch:
https://hg.mozilla.org/releases/mozilla-aurora/rev/2fb0a358eaf6
status-firefox15: --- → fixed
status-firefox16: --- → fixed
Status: RESOLVED → VERIFIED
status-firefox15: fixed → verified
status-firefox16: fixed → verified
status-firefox17: --- → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: