771516 - \ character in name prevents installation

Status: VERIFIED WONTFIX

(Firefox for Android Graveyard :: Web Apps (PWAs), defect)

Description

[Aaron Train [:aaronmt]]

Is this expected behaviour? With a name such as: '!:;/<>\|?', I am unable to install the web-application (at least on testmanifest). There is nothing captured in GeckoOutput.

----

{
  "name":"!:;/<>\|?",
  "description":"This app has been automatically generated by testmanifest.com",
  "version":"1.0",
  "icons":{
    "16":"http://testmanifest.com/icon-16.png",
    "48":"http://testmanifest.com/icon-48.png",
    "128":"http://testmanifest.com/icon-128.png"
  },
  "installs_allowed_from":[
    "*"
  ]
}

------

Samsung Galaxy Nexus (Android 4.1)
Nightly (07/06)

Comment 1

[Jason Smith [:jsmith]]

At a very minimum even if this isn't allowed, we should be correctly reporting an error back. Not sure what sanitization rules is being followed for app names on web apps for android.

Mark and Wes - Can you clarify?

Comment 2

[Wesley Johnston (:wesj)]

Right now that above manifest is failing before it ever gets to us. It looks like Webapps.js sends out an error:

http://mxr.mozilla.org/mozilla-central/source/dom/apps/src/Webapps.js#147

but we're not watching for those yet? It looks like pages can grab them and since they are cancellable, I guess we can assume if we get one its because the page didn't handle it. But that's a separate bug.... will file.

Comment 4

[Wesley Johnston (:wesj)]

OK, so the issue in your manifest is the \ character, which makes us the JSON parser look for an escape sequence and bail when it doesn't find one. We should catch these errors and show a toast or something. That will mean strings. I'll tackle this tomorrow.

Comment 5

[Wesley Johnston (:wesj)]

If it helps things, I don't think not being able to insert an invalid \ character in JSON should block. The characters we were really worried about (?, :, !, etc) work fine in my testing.

Comment 6

[Jason Smith [:jsmith]]

(In reply to Wesley Johnston (:wesj) from comment #5)
> If it helps things, I don't think not being able to insert an invalid \
> character in JSON should block. The characters we were really worried about
> (?, :, !, etc) work fine in my testing.

Completely agree. Marking for re-triage. I haven't seen any apps on desktop make use of the \ character in the name of the app, so I definitely agree this probably isn't a blocker.

Comment 7

[Jason Smith [:jsmith]]

\ is not valid JSON, so this is a won't fix. Marking dev-doc-needed - we should indicate this in the MDN doc about valid JSON rules.