77153 - Need to update XPCOM samples to reflect correct, modern usage

Status: RESOLVED FIXED

(Core :: XPCOM, defect, P3)

Description

[Mike Shaver (:shaver emeritus)]

I mean, we use NSGetFactory.  Gimme a break.

Comment 1

[Mike Shaver (:shaver emeritus)]

0.9.2, unless kandrot wants to do some ownerly hacking here.

Ed?

Comment 2

[Edward Kandrot]

Mik,

What is correct modern usage?  I had not realized tha NSGetFactory was not used,
for example.  What should be done?  I am the default XPCOM bug assignee, but I
do not know what XPCOM should do, vs what it used to do.  Is there samples or
docs on this?  Thanks.

-Edward

Comment 3

[Mike Shaver (:shaver emeritus)]

Asa just told me that we shipped 0.9.2!  Who knew?

Comment 4

[chris hofmann]

->0.9.5 since we have run out of time

Comment 5

[Mike Shaver (:shaver emeritus)]

I'm going to give this to dougt, in hopes that he can make it part of the API
review-and-freeze plan.

Doug: if this offends you deeply, feel free to throw it back.

Comment 6

[Doug Turner (:dougt)]

mike, can you double check me, but I think that xpcom/samples are good to go. 
(assuming that I can get my ass in gear and make that NS_IMPL_NSGETMODULE safe
to use by putting it into the xpcom/glue library. I have a bug for that)

Comment 7

[Doug Turner (:dougt)]

we need to remove the damn nsCRT/string dependency.  Once this dependency is 
broken, the samples (outside of a minor makefile change) will be completly 
reusabe between different version of XPCOM (at least going forward in time).

Comment 8

[Doug Turner (:dougt)]

reconsider please.

Comment 9

[Doug Turner (:dougt)]

We want to be using the correct version of the glue library:

Index: xpcom/sample/Makefile.in
===================================================================
RCS file: /cvsroot/mozilla/xpcom/sample/Makefile.in,v
retrieving revision 1.19
diff -u -r1.19 Makefile.in
--- xpcom/sample/Makefile.in	25 Apr 2002 02:52:20 -0000	1.19
+++ xpcom/sample/Makefile.in	17 May 2002 02:16:58 -0000
@@ -63,13 +63,13 @@
 
 # seperate libraries linked in.
 EXTRA_DSO_LDOPTS = \
-
	$(DIST)/lib/$(LIB_PREFIX)xpcomglue.$(LIB_SUFFIX) \
+
	$(DIST)/lib/$(LIB_PREFIX)xpcomglue_s.$(LIB_SUFFIX) \
 
	$(XPCOM_LIBS) \
 
	$(NSPR_LIBS) \
 
	$(NULL)
 
 LIBS            = \
-
	$(DIST)/lib/$(LIB_PREFIX)xpcomglue.$(LIB_SUFFIX) \
+
	$(DIST)/lib/$(LIB_PREFIX)xpcomglue_s.$(LIB_SUFFIX) \
 
	$(DIST)/lib/$(LIB_PREFIX)string_s.$(LIB_SUFFIX) \
 
	$(DIST)/lib/$(LIB_PREFIX)string_obsolete_s.$(LIB_SUFFIX) \
 
	$(XPCOM_LIBS) \


With this change, there are no unfrozen dependencies.

Comment 10

[Doug Turner (:dougt)]

that above patch is unneed.  Marking fixed.