Closed
Bug 771608
Opened 12 years ago
Closed 12 years ago
Time tag causes crash with text based profile
Categories
(Core :: Gecko Profiler, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: BenWa, Assigned: BenWa)
References
Details
Attachments
(1 file)
|
989 bytes,
patch
|
ehsan.akhgari
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #639753 -
Flags: review?(ehsan)
Comment on attachment 639753 [details] [diff] [review]
patch
One thought -- to prevent this from happening in the future, it might be better to explicitly list out all the tags here (can be done in a switch statement, since they're all characters), and have an assertion failure in the default case. Though I think you want to get rid of the text based profiles entirely, so maybe not a big deal.
|
||
Comment 2•12 years ago
|
||
Comment on attachment 639753 [details] [diff] [review]
patch
Review of attachment 639753 [details] [diff] [review]:
-----------------------------------------------------------------
What Vlad said, but that can happen in a followup.
Attachment #639753 -
Flags: review?(ehsan) → review+
|
|
||
Comment 3•12 years ago
|
||
Assignee: nobody → bgirard
Target Milestone: --- → mozilla16
|
||
Comment 4•12 years ago
|
||
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•