Time tag causes crash with text based profile

RESOLVED FIXED in mozilla16

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 639753 [details] [diff] [review]
patch
Attachment #639753 - Flags: review?(ehsan)
Comment on attachment 639753 [details] [diff] [review]
patch

One thought -- to prevent this from happening in the future, it might be better to explicitly list out all the tags here (can be done in a switch statement, since they're all characters), and have an assertion failure in the default case.  Though I think you want to get rid of the text based profiles entirely, so maybe not a big deal.
Comment on attachment 639753 [details] [diff] [review]
patch

Review of attachment 639753 [details] [diff] [review]:
-----------------------------------------------------------------

What Vlad said, but that can happen in a followup.
Attachment #639753 - Flags: review?(ehsan) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/680840cf39b3
Assignee: nobody → bgirard
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/680840cf39b3
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Duplicate of this bug: 772223
You need to log in before you can comment on or make changes to this bug.