Check sameDocument on location change

RESOLVED FIXED in Firefox 15

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: bnicholson, Assigned: bnicholson)

Tracking

({regression})

unspecified
Firefox 16
ARM
Android
regression
Points:
---

Firefox Tracking Flags

(firefox15 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 639760 [details] [diff] [review]
patch

We used to return early if sameDocument was true, but it looks like we lost this in bug 753102.
Attachment #639760 - Flags: review?(mark.finkle)
(Assignee)

Updated

5 years ago
Keywords: regression
Comment on attachment 639760 [details] [diff] [review]
patch

Looks like this was removed because we moved setTitle(...) runnable:
http://hg.mozilla.org/mozilla-central/rev/9af545c94146#l6.262

To here:
http://hg.mozilla.org/mozilla-central/rev/9af545c94146#l3.70

Note the "//if (sameDocument)"

Yes, we need to keep this check in handleLocationChange. Can you nuke the "//if (sameDocument)" comment too?
Attachment #639760 - Flags: review?(mark.finkle) → review+
We need to uplift this too
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/480c74c5e36d
(Assignee)

Comment 4

5 years ago
Comment on attachment 639760 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 753102
User impact if declined: unexpected behavior when opening anchor from page (e.g., favicon disappears)
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): very low risk
String or UUID changes made by this patch: none
Attachment #639760 - Flags: approval-mozilla-aurora?
https://hg.mozilla.org/mozilla-central/rev/480c74c5e36d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16

Updated

5 years ago
Attachment #639760 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
(Assignee)

Comment 6

5 years ago
http://hg.mozilla.org/releases/mozilla-aurora/rev/189d7177a904
status-firefox15: --- → fixed
You need to log in before you can comment on or make changes to this bug.