771621 - Check sameDocument on location change

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Brian Nicholson (:bnicholson)]

Attachment: patch

We used to return early if sameDocument was true, but it looks like we lost this in bug 753102.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 639760 [details] [diff] [review]
patch

Looks like this was removed because we moved setTitle(...) runnable:
http://hg.mozilla.org/mozilla-central/rev/9af545c94146#l6.262

To here:
http://hg.mozilla.org/mozilla-central/rev/9af545c94146#l3.70

Note the "//if (sameDocument)"

Yes, we need to keep this check in handleLocationChange. Can you nuke the "//if (sameDocument)" comment too?

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

We need to uplift this too

Comment 3

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/480c74c5e36d

Comment 4

[Brian Nicholson (:bnicholson)]

Comment on attachment 639760 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 753102
User impact if declined: unexpected behavior when opening anchor from page (e.g., favicon disappears)
Testing completed (on m-c, etc.): just landed on inbound
Risk to taking this patch (and alternatives if risky): very low risk
String or UUID changes made by this patch: none

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/480c74c5e36d

Comment 6

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/189d7177a904