Note: There are a few cases of duplicates in user autocompletion which are being worked on.

"Assertion failure: node" in ValidateCurrentNode

RESOLVED FIXED in mozilla16

Status

()

Core
DOM: Core & HTML
--
critical
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: Jesse Ruderman, Assigned: ayg)

Tracking

(Blocks: 1 bug, {assertion, regression, testcase})

Trunk
mozilla16
assertion, regression, testcase
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
Created attachment 639769 [details]
testcase

Assertion failure: node, at content/base/src/nsRange.cpp:1457

This assertion is part of ValidateCurrentNode, a function added in bug 766426.
(Reporter)

Comment 1

5 years ago
Created attachment 639770 [details]
stack trace

Updated

5 years ago
Assignee: nobody → ayg
Created attachment 640054 [details] [diff] [review]
Patch

This turns out not to have anything to do with fullscreen.  What CutContents does in this case is:

1) Create an iterator and call Last()

2) Save the current node in a local variable

3) Call Prev() on iterator so that if we delete the local variable, the iterator points to the next node we should delete

4) Delete the node

5) Call ValidateCurrentNode() on the iterator

The problem is that if any mutation occurs in step (4), and the node we just removed is the last one, the iterator will be done.  Then ValidateCurrentNode() will try to get the current node, which will be null.  Then it will assert.  In this case, we should just say it's valid.

Try: https://tbpl.mozilla.org/?tree=Try&rev=09c3dfd3d7ce
Attachment #640054 - Flags: review?(bugs)
Status: NEW → ASSIGNED

Updated

5 years ago
Attachment #640054 - Flags: review?(bugs) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/8129536fb25c
Flags: in-testsuite+
OS: Mac OS X → All
Hardware: x86_64 → All
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/8129536fb25c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Component: DOM: Traversal-Range → DOM: Core & HTML
Product: Core → Core
You need to log in before you can comment on or make changes to this bug.