771664 - Automatic refunds are failing

Status: VERIFIED FIXED

(Marketplace Graveyard :: Payments/Refunds, defect)

Description

[krupa raj[:krupa]]

Attachment: screenshot

steps to reproduce:
1. Purchase https://marketplace-dev.allizom.org/en-US/app/private-yacht/
2. Immediately after purchase(< 30 minutes), try to get a refund.

expected behavior:
Automatic refund is successful.

observed behavior:
Automatic Refund fails with "A refund cannot be applied for yet. Please try again later. If this error persists contact [e-mail]. "

Comment 1

[Andy McKay]

Hmm, this looks like a different error. This means the IPN wasn't in yet.

An error was seen in the logs on the IPN for a refund:

ul  6 14:41:20 dev1.addons.phx1.mozilla.com: [<anon>][173.0.82.126] z.paypal:ERROR bad operand type for unary -: 'unicode'#012<WSGIRequest#012GET:<Que...

Comment 2

[Andy McKay]

The error in comment 1 is fixed at least.

https://github.com/mozilla/zamboni/commit/9e0a9d

Comment 3

[Wil Clouser [:clouserw]]

This bug sounds like there was a delay in the purchase confirmation.  The message clearly stated the problem and the solution.  That sounds like as good as this is going to get so I'm going to close the bug.

Comment 4

[Andy McKay]

I think this is because the pay check was marking the payment as completed in solitude. So the IPN got ignored by solitude and zamboni didn't update the contribution so allowing refunds.

I think I got this in:

https://github.com/mozilla/solitude/commit/19caf04fa1b54bedd45ec39da9c9cd8257fdddbb

Comment 5

[Andy McKay]

Yep think that's it.

Comment 6

[krupa raj[:krupa]]

verified fixed.

Comment 7

[krupa raj[:krupa]]

Attachment: post-fix screenshot