d-pad navigation of browser toolbar in unpredictable

RESOLVED FIXED in Firefox 15

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

unspecified
Firefox 16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox15 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Sometimes you need to press up to get to the site security button. It should all be linear left to right. I think there are issues with the way the toolbar is defined, and the show/hiding of elements.
(Assignee)

Comment 1

5 years ago
Created attachment 639868 [details] [diff] [review]
Fix toolbar focus order.
Attachment #639868 - Flags: review?(sriram)
(Assignee)

Comment 2

5 years ago
Created attachment 639874 [details] [diff] [review]
Bug 771726 - Fix toolbar focus order.

Slightly less silly. Sorry.
Attachment #639874 - Flags: review?(sriram)
(Assignee)

Comment 3

5 years ago
Comment on attachment 639868 [details] [diff] [review]
Fix toolbar focus order.

Sorry, this one should have been obsoleted.
Attachment #639868 - Attachment is obsolete: true
Attachment #639868 - Flags: review?(sriram)
Comment on attachment 639874 [details] [diff] [review]
Bug 771726 - Fix toolbar focus order.

Review of attachment 639874 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
I am a fan of

for (View view : mFocusOrder) {
 ... use view as normal ...
}

r+ with that change.
Attachment #639874 - Flags: review?(sriram) → review+
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/e3c42c6b420e
Assignee: nobody → eitan
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/e3c42c6b420e
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 15 → Firefox 16
(Assignee)

Comment 7

5 years ago
Comment on attachment 639874 [details] [diff] [review]
Bug 771726 - Fix toolbar focus order.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 771726
User impact if declined: Keyboard users will not have consistent access to browser toolbar.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): No foreseeable risk.
String or UUID changes made by this patch: None
Attachment #639874 - Flags: approval-mozilla-aurora?

Updated

5 years ago
Attachment #639874 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+

Comment 8

5 years ago
Landed on Eitan's behalf: http://hg.mozilla.org/releases/mozilla-aurora/rev/ecb63f8448af
status-firefox15: --- → fixed
You need to log in before you can comment on or make changes to this bug.