Closed Bug 771726 Opened 11 years ago Closed 11 years ago

d-pad navigation of browser toolbar in unpredictable

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox15 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

Details

Attachments

(1 file, 1 obsolete file)

Bug 771726 - Fix toolbar focus order.
3.47 KB, patch
sriram
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
Sometimes you need to press up to get to the site security button. It should all be linear left to right. I think there are issues with the way the toolbar is defined, and the show/hiding of elements.
Attached patch Fix toolbar focus order. (obsolete) — — Splinter Review
Attachment #639868 - Flags: review?(sriram)
Slightly less silly. Sorry.
Attachment #639874 - Flags: review?(sriram)
Comment on attachment 639868 [details] [diff] [review]
Fix toolbar focus order.

Sorry, this one should have been obsoleted.
Attachment #639868 - Attachment is obsolete: true
Attachment #639868 - Flags: review?(sriram)
Comment on attachment 639874 [details] [diff] [review]
Bug 771726 - Fix toolbar focus order.

Review of attachment 639874 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
I am a fan of

for (View view : mFocusOrder) {
 ... use view as normal ...
}

r+ with that change.
Attachment #639874 - Flags: review?(sriram) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/e3c42c6b420e
Assignee: nobody → eitan
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/e3c42c6b420e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 15 → Firefox 16
Comment on attachment 639874 [details] [diff] [review]
Bug 771726 - Fix toolbar focus order.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 771726
User impact if declined: Keyboard users will not have consistent access to browser toolbar.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): No foreseeable risk.
String or UUID changes made by this patch: None
Attachment #639874 - Flags: approval-mozilla-aurora?
Attachment #639874 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.