771726 - d-pad navigation of browser toolbar in unpredictable

Status: RESOLVED FIXED

Description

[Eitan Isaacson [:eeejay]]

Sometimes you need to press up to get to the site security button. It should all be linear left to right. I think there are issues with the way the toolbar is defined, and the show/hiding of elements.

Comment 1

[Eitan Isaacson [:eeejay]]

Created attachment 639868 [details] [diff] [review]
Fix toolbar focus order.

Comment 2

[Eitan Isaacson [:eeejay]]

Created attachment 639874 [details] [diff] [review]
Bug 771726 - Fix toolbar focus order.

Slightly less silly. Sorry.

Comment 3

[Eitan Isaacson [:eeejay]]

Comment on attachment 639868 [details] [diff] [review]
Fix toolbar focus order.

Sorry, this one should have been obsoleted.

Comment 4

[Sriram Ramasubramanian [:sriram]]

Comment on attachment 639874 [details] [diff] [review]
Bug 771726 - Fix toolbar focus order.

Review of attachment 639874 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
I am a fan of

for (View view : mFocusOrder) {
 ... use view as normal ...
}

r+ with that change.

Comment 5

[Eitan Isaacson [:eeejay]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/e3c42c6b420e

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/e3c42c6b420e

Comment 7

[Eitan Isaacson [:eeejay]]

Comment on attachment 639874 [details] [diff] [review]
Bug 771726 - Fix toolbar focus order.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): 771726
User impact if declined: Keyboard users will not have consistent access to browser toolbar.
Testing completed (on m-c, etc.): Yes.
Risk to taking this patch (and alternatives if risky): No foreseeable risk.
String or UUID changes made by this patch: None

Comment 8

[Marco Zehe (:MarcoZ)]

Landed on Eitan's behalf: http://hg.mozilla.org/releases/mozilla-aurora/rev/ecb63f8448af