Closed
Bug 771726
Opened 12 years ago
Closed 12 years ago
d-pad navigation of browser toolbar in unpredictable
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(firefox15 fixed)
RESOLVED
FIXED
Firefox 16
Tracking | Status | |
---|---|---|
firefox15 | --- | fixed |
People
(Reporter: eeejay, Assigned: eeejay)
Details
Attachments
(1 file, 1 obsolete file)
3.47 KB,
patch
|
sriram
:
review+
akeybl
:
approval-mozilla-aurora+
|
Details | Diff | Splinter Review |
Sometimes you need to press up to get to the site security button. It should all be linear left to right. I think there are issues with the way the toolbar is defined, and the show/hiding of elements.
Assignee | ||
Comment 1•12 years ago
|
||
Attachment #639868 -
Flags: review?(sriram)
Assignee | ||
Comment 2•12 years ago
|
||
Slightly less silly. Sorry.
Attachment #639874 -
Flags: review?(sriram)
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 639868 [details] [diff] [review] Fix toolbar focus order. Sorry, this one should have been obsoleted.
Attachment #639868 -
Attachment is obsolete: true
Attachment #639868 -
Flags: review?(sriram)
Comment 4•12 years ago
|
||
Comment on attachment 639874 [details] [diff] [review] Bug 771726 - Fix toolbar focus order. Review of attachment 639874 [details] [diff] [review]: ----------------------------------------------------------------- This looks good to me. I am a fan of for (View view : mFocusOrder) { ... use view as normal ... } r+ with that change.
Attachment #639874 -
Flags: review?(sriram) → review+
Assignee | ||
Comment 5•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/e3c42c6b420e
Assignee: nobody → eitan
Target Milestone: --- → Firefox 15
Comment 6•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/e3c42c6b420e
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 15 → Firefox 16
Assignee | ||
Comment 7•12 years ago
|
||
Comment on attachment 639874 [details] [diff] [review] Bug 771726 - Fix toolbar focus order. [Approval Request Comment] Bug caused by (feature/regressing bug #): 771726 User impact if declined: Keyboard users will not have consistent access to browser toolbar. Testing completed (on m-c, etc.): Yes. Risk to taking this patch (and alternatives if risky): No foreseeable risk. String or UUID changes made by this patch: None
Attachment #639874 -
Flags: approval-mozilla-aurora?
Updated•12 years ago
|
Attachment #639874 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment 8•12 years ago
|
||
Landed on Eitan's behalf: http://hg.mozilla.org/releases/mozilla-aurora/rev/ecb63f8448af
status-firefox15:
--- → fixed
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•