Closed Bug 771727 Opened 11 years ago Closed 11 years ago

d-pad gets stuck in tabs panel after it goes away

Categories

(Firefox for Android Graveyard :: General, defect)

Product:
Firefox for Android Graveyard
Component:
General
Platform:
ARM
Android
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox15 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 16
Tracking Flags:
Tracking Status
firefox15 --- fixed

People

(Reporter: eeejay, Assigned: eeejay)

Details

(Keywords: access)

Attachments

(1 file, 1 obsolete file)

Block focus in tabs panel when it is hidden.
1.99 KB, patch
sriram
: review+
akeybl
: approval-mozilla-aurora+
Details | Diff | Splinter Review 
This is probably because it is never explicitly hidden.
Comment on attachment 639869 [details] [diff] [review]
Truely hide tabs panel so the directional controller does not stay in it.

Review of attachment 639869 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. I'm not sure if show/hide of tabs-ui can race with animation.
If so, we might need to look into other ways/places to do this change.
Attachment #639869 - Flags: review?(sriram) → review+
Keywords: access
Here, this just toggles focus settings.
Attachment #639869 - Attachment is obsolete: true
Attachment #641244 - Flags: review?(sriram)
Comment on attachment 641244 [details] [diff] [review]
Block focus in tabs panel when it is hidden.

Review of attachment 641244 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Attachment #641244 - Flags: review?(sriram) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/61d879a04b01
Assignee: nobody → eitan
Target Milestone: --- → Firefox 15
https://hg.mozilla.org/mozilla-central/rev/61d879a04b01
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 15 → Firefox 16
Comment on attachment 641244 [details] [diff] [review]
Block focus in tabs panel when it is hidden.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): unknown
User impact if declined: If the tabs panel goes away, accessibility is not notified correctly, so users think they're still in the tab panel even though they are not. Keyboard behavior is inconsistent and may produce unpredictable results.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): None known.
String or UUID changes made by this patch: None.
Attachment #641244 - Flags: approval-mozilla-aurora?
Testing completed (on m-c, etc.): Yes, verified in a local build.
Comment on attachment 641244 [details] [diff] [review]
Block focus in tabs panel when it is hidden.

[Triage Comment]
Approved for FF15 given that the a11y reward outweighs the near-zero risk.
Attachment #641244 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.