d-pad gets stuck in tabs panel after it goes away

RESOLVED FIXED in Firefox 15

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

({access})

unspecified
Firefox 16
ARM
Android
access
Points:
---

Firefox Tracking Flags

(firefox15 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
This is probably because it is never explicitly hidden.
(Assignee)

Comment 1

5 years ago
Created attachment 639869 [details] [diff] [review]
Truely hide tabs panel so the directional controller does not stay in it.
Attachment #639869 - Flags: review?(sriram)
Comment on attachment 639869 [details] [diff] [review]
Truely hide tabs panel so the directional controller does not stay in it.

Review of attachment 639869 [details] [diff] [review]:
-----------------------------------------------------------------

This looks fine. I'm not sure if show/hide of tabs-ui can race with animation.
If so, we might need to look into other ways/places to do this change.
Attachment #639869 - Flags: review?(sriram) → review+

Updated

5 years ago
Keywords: access
(Assignee)

Comment 3

5 years ago
Created attachment 641244 [details] [diff] [review]
Block focus in tabs panel when it is hidden.

Here, this just toggles focus settings.
Attachment #639869 - Attachment is obsolete: true
Attachment #641244 - Flags: review?(sriram)
Comment on attachment 641244 [details] [diff] [review]
Block focus in tabs panel when it is hidden.

Review of attachment 641244 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good to me.
Attachment #641244 - Flags: review?(sriram) → review+
(Assignee)

Comment 5

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/61d879a04b01
Assignee: nobody → eitan
Target Milestone: --- → Firefox 15

Comment 6

5 years ago
https://hg.mozilla.org/mozilla-central/rev/61d879a04b01
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: Firefox 15 → Firefox 16

Comment 7

5 years ago
Comment on attachment 641244 [details] [diff] [review]
Block focus in tabs panel when it is hidden.

[Approval Request Comment]
Bug caused by (feature/regressing bug #): unknown
User impact if declined: If the tabs panel goes away, accessibility is not notified correctly, so users think they're still in the tab panel even though they are not. Keyboard behavior is inconsistent and may produce unpredictable results.
Testing completed (on m-c, etc.): 
Risk to taking this patch (and alternatives if risky): None known.
String or UUID changes made by this patch: None.
Attachment #641244 - Flags: approval-mozilla-aurora?

Comment 8

5 years ago
Testing completed (on m-c, etc.): Yes, verified in a local build.

Comment 9

5 years ago
Comment on attachment 641244 [details] [diff] [review]
Block focus in tabs panel when it is hidden.

[Triage Comment]
Approved for FF15 given that the a11y reward outweighs the near-zero risk.
Attachment #641244 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
http://hg.mozilla.org/releases/mozilla-aurora/rev/7e10f72cdfa9
status-firefox15: --- → fixed
You need to log in before you can comment on or make changes to this bug.