Closed Bug 771795 Opened 9 years ago Closed 9 years ago

Stop over-invalidating SVG

Categories

(Core :: SVG, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: jwatt, Assigned: jwatt)

Details

(Keywords: perf)

Attachments

(1 file)

We are currently massively over invalidating, and no longer need to any more.
Attached patch patchSplinter Review
Attachment #639960 - Flags: review?(dholbert)
Keywords: perf
Summary: Stop over invalidating SVG → Stop over-invalidating SVG
Seems a good time to address this comment:
// XXXSDL Let FinishAndStoreOverflow do this.

...or remove it entirely if no longer applicable.
(In reply to Jet Villegas (:jet) from comment #2)
> Seems a good time to address this comment:
> // XXXSDL Let FinishAndStoreOverflow do this.

It's not clear right now how that code should look after Matt's DLBI work, so for now I'd just like to leave it as it is. Besides that, the rapid release process rules demand that I'm able to disable or back out my work if it turns out something bad requires it on branches, so I'd rather leave the "easy disable" route intact.
Comment on attachment 639960 [details] [diff] [review]
patch

(Stealing with permission.)
Attachment #639960 - Flags: review?(dholbert) → review+
https://hg.mozilla.org/mozilla-central/rev/fa1bf35aae2e
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.