771819 - IdentityCryptoService.cpp:547:64: warning: narrowing conversion of ‘((hashAlg == (SECOidTag)4u) ? 20 : 32)’ from ‘int’ to ‘unsigned int’ inside { } [-Werror=narrowing]

Status: RESOLVED FIXED

(Core Graveyard :: Identity, defect)

Description

[Daniel Holbert [:dholbert]]

New GCC 4.7 build warning:

{
toolkit/identity/IdentityCryptoService.cpp:547:64: warning: narrowing conversion of ‘((hashAlg == (SECOidTag)4u) ? 20 : 32)’ from ‘int’ to ‘unsigned int’ inside { } [-Werror=narrowing]
}

For this chunk of code:
http://hg.mozilla.org/integration/mozilla-inbound/diff/88070ff09ccd/toolkit/identity/IdentityCryptoService.cpp#l1.550


>        SECItem hashItem = { siBuffer, hash,
>                             hashAlg == SEC_OID_SHA1 ? 20 : 32 };

Looks like the compiler is treating the result of "bool ? 20 : 32" as a signed int, and then has to jam that into an unsigned int (for some member-var in SECItem)

Simple fix -- just add a "u" suffix to the raw numbers.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix

(forgot to mention: this warning is only on inbound so far, since the cset hasn't made it over to mozilla-central yet.)

Comment 3

[Matthew N. [:MattN]]

Comment on attachment 639973 [details] [diff] [review]
fix

Fixed by Gavin in https://hg.mozilla.org/mozilla-central/rev/1751d97cc9e4