options.loadReason is undefined on 1.8

RESOLVED FIXED

Status

Add-on SDK
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: canuckistani, Assigned: irakli)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Reported here: http://is.gd/EbT0p1

Repro:

https://builder.addons.mozilla.org/addon/1064871/latest/

By design?
I think we need to roll a 1.8.1 to fix this, ASAP.
We probably need to cherry-pick this change into release:

https://github.com/mozilla/addon-sdk/commit/cda1c015ce31cf890f93d32cd0b15b741793cf47
(In reply to Jeff Griffiths from comment #0)
> Repro:
> 
> https://builder.addons.mozilla.org/addon/1064871/latest/
This still fails for me with cda1c015 cherry picked (after cleaning up the merge conflicts.
Irakli, is there anything else before that commit that needed to be included as well for this to work?
Assignee: nobody → rFobic
Created attachment 640362 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/483

Pointer to Github pull-request
Attachment #640362 - Flags: review?(dtownsend+bugmail)
Attachment #640362 - Flags: feedback?(kwierso)
Attachment #640362 - Flags: review?(dtownsend+bugmail) → review+

Comment 5

5 years ago
Commit pushed to release at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1992402871cbe3c619a4c18070dda312269ad2ec
Merge pull request #483 from Gozala/hotfix/load-reason@771825

Bug 771825 - options.loadReason is undefined on 1.8 r=mossop

Updated

5 years ago
Attachment #640362 - Flags: feedback?(kwierso) → feedback+

Updated

5 years ago
Blocks: 772294

Comment 6

5 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1992402871cbe3c619a4c18070dda312269ad2ec
Merge pull request #483 from Gozala/hotfix/load-reason@771825

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Duplicate of this bug: 778604
You need to log in before you can comment on or make changes to this bug.