771825 - options.loadReason is undefined on 1.8

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Jeff Griffiths (:canuckistani) (:⚡︎)]

Reported here: http://is.gd/EbT0p1

Repro:

https://builder.addons.mozilla.org/addon/1064871/latest/

By design?

Comment 1

[Jeff Griffiths (:canuckistani) (:⚡︎)]

I think we need to roll a 1.8.1 to fix this, ASAP.

Comment 2

[Jeff Griffiths (:canuckistani) (:⚡︎)]

We probably need to cherry-pick this change into release:

https://github.com/mozilla/addon-sdk/commit/cda1c015ce31cf890f93d32cd0b15b741793cf47

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

(In reply to Jeff Griffiths from comment #0)
> Repro:
> 
> https://builder.addons.mozilla.org/addon/1064871/latest/
This still fails for me with cda1c015 cherry picked (after cleaning up the merge conflicts.
Irakli, is there anything else before that commit that needed to be included as well for this to work?

Comment 4

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/483

Pointer to Github pull-request

Comment 5

[[github robot]]

Commit pushed to release at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1992402871cbe3c619a4c18070dda312269ad2ec
Merge pull request #483 from Gozala/hotfix/load-reason@771825

Bug 771825 - options.loadReason is undefined on 1.8 r=mossop

Comment 6

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1992402871cbe3c619a4c18070dda312269ad2ec
Merge pull request #483 from Gozala/hotfix/load-reason@771825