77185 - update mozilla user agent on branch to 0.9 and trunk to 0.9+

Status: VERIFIED FIXED

(SeaMonkey :: Build Config, defect, P1)

Description

[Asa Dotzler [:asa]]

Reminder that we need to update the user agent when we branch.  We need to set
it to Mozilla 0.9 on the branch and Mozilla 0.9+ on the trunk.  This is a spinn
off from bug 65764

Comment 1

[Jon Granrose]

reassign to kysmith since IIRC he changed it last milestone.

Kyle - this is two changes.  one on the trunk, and one on the branch, so be sure
to check the branch change into the branch (everyone makes that mistake at least
once). check with leaf or myself if you have any questions.  this needs to go in
as soon as the mozilla 0.9 branch is cut.

Comment 2

[timeless]

don't forget to find someone to change the finder resource fork info thing

Comment 3

[André Dahlqvist]

Has this been done, now that we've branched?

Comment 4

[Jon Granrose]

patience is a virtue.  we just branched last night and still have 18 other open
0.9 bugs.  Kyle's working on it and we should have it in by Monday or Tuesday.

Comment 5

[kysmith0 (gone)]

It looks to me that this is set the same on the branch as on the trunk, i.e.

pref("general.useragent.misc", "rv:0.8.1+");

Do I update 'em both to be "rv:0.9+"? 

Comment 6

[Jon Granrose]

no, change 0.8.1 to 0.9, so it would be "0.9" on the branch and "0.9+" on the
trunk.  the + means it's more than that, i.e. 0.9 plus other stuff that has
landed on the trunk since 0.9 was released.

Comment 7

[kysmith0 (gone)]

branch diffs

[kysmith@foxhound init]$ cvs diff -u all.js 
Index: all.js 
=================================================================== 
RCS file: /cvsroot/mozilla/modules/libpref/src/init/all.js,v 
retrieving revision 3.224 
diff -u -r3.224 all.js 
--- all.js                                                                     2 
001/04/21 22:22:09                                                             3 
.224 
+++ all.js                                                                     2 
001/05/01 19:56:00 
@@ -28,7 +28,7 @@ 
 pref("keyword.URL", "http://keyword.netscape.com/keyword/"); 
 pref("keyword.enabled", true); 
 pref("general.useragent.locale", "chrome://navigator/locale/navigator.propertie 
s"); 
-pref("general.useragent.misc", "rv:0.8.1+"); 
+pref("general.useragent.misc", "rv:0.9"); 
  
 pref("general.startup.browser",             true); 
 pref("general.startup.mail",                false); 

Comment 8

[kysmith0 (gone)]

trunk diffs

[kysmith@foxhound init]$ cvs diff -u all.js  
Index: all.js 
=================================================================== 
RCS file: /cvsroot/mozilla/modules/libpref/src/init/all.js,v 
retrieving revision 3.226 
diff -u -r3.226 all.js 
--- all.js                                                                     2 
001/04/28 07:59:12                                                             3 
.226 
+++ all.js                                                                     2 
001/05/01 19:58:11 
@@ -28,7 +28,7 @@ 
 pref("keyword.URL", "http://keyword.netscape.com/keyword/"); 
 pref("keyword.enabled", true); 
 pref("general.useragent.locale", "chrome://navigator/locale/navigator.propertie 
s"); 
-pref("general.useragent.misc", "rv:0.8.1+"); 
+pref("general.useragent.misc", "rv:0.9+"); 
  
 pref("general.startup.browser",             true); 
 pref("general.startup.mail",                false);

Comment 9

[Daniel (Leaf) Nunes]

r=leaf, a=leaf for committing on the branch.

Comment 10

[Christopher Blizzard (:blizzard)]

Checked in on the tip and the branch.

Comment 11

[Andreas Franke (gone)]

> ------- Additional Comments From [e-mail] 2001-04-23 21:32 -------
> 
> don't forget to find someone to change the finder resource fork info thing

Has this been done? Or do we need a separate bug for it?

Comment 12

[Jon Granrose]

reopening.  still need to update nsMacVersion.r.  Too late for the branch, but
should do this on the trunk.

Comment 13

[kysmith0 (gone)]

Over to Leaf since I can't update mozilla tree. 

Comment 14

[Daniel (Leaf) Nunes]

This must have been committed already.

Comment 15

[Andreas Franke (gone)]

Reopening. 

From http://lxr.mozilla.org/seamonkey/source/xpfe/bootstrap/nsMacVersion.r :

 28 // Version Numbers //
 29 
 30 #define         VERSION_MAJOR         0
 31 #define         VERSION_MINOR         0x80    // revision & fix in BCD
 32 #define         VERSION_KIND          alpha   // alpha, beta, or final
 33 #define         VERSION_MICRO         0               // internal stage:
alpha or beta number
 34 
 35 
 36 // Version Strings (Finder's Get Info dialog box) //
 37 
 38 #define         VERSION_STRING        "0.8+"

"0.8+" seems to be pretty old to me.

Comment 16

[J.J. Enser]

I thought the '+' thing was for the trunk ?
Sorry if this issue is raised one more time, but it seems like some clarification 
is still needed.

And btw, nsMacVersion.r on the trunk says 0.8+ ... not good, as Andreas just 
pointed out :-/

Comment 17

[Daniel (Leaf) Nunes]

bumping over to jj; can you make this change? It should be 0.9+ on the trunk.

Comment 18

[J.J. Enser]

Here's the patch I'm about to check-in:

Index: mozilla/xpfe/bootstrap/nsMacVersion.r
===================================================================
RCS file: /cvsroot/mozilla/xpfe/bootstrap/nsMacVersion.r,v
retrieving revision 1.14
diff -u -0 -r1.14 nsMacVersion.r
--- nsMacVersion.r	2001/03/06 05:20:05	1.14
+++ nsMacVersion.r	2001/05/17 01:42:16
@@ -31 +31 @@
-#define		VERSION_MINOR			0x80	// revision & fix in BCD
+#define		VERSION_MINOR			0x90	// revision & fix in BCD
@@ -38 +38 @@
-#define		VERSION_STRING			"0.8+"
+#define		VERSION_STRING			"0.9+"

Comment 19

[J.J. Enser]

fix checked in

Comment 20

[Jon Granrose]

verified.