771870 - adding files to js/src seems to require a clobber on tinderbox, sometimes

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Luke Wagner [:luke]]

Here is one example:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b0e6294a7c
with log:
  https://tbpl.mozilla.org/php/getParsedLog.php?id=13324602&tree=Mozilla-Inbound&full=1

Here is another:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/8417741974ba

Both involve adding files to js/src/Makefile.in that are not INSTALLED_HEADERS.

Another clue is that philor pointed out that these are the only csets to add files after bug 748001.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comparing a good log to a failed log, one thing that seems to have gone wrong is that a good log:

https://tbpl.mozilla.org/php/getParsedLog.php?id=13317288&tree=Mozilla-Inbound

contains the export line:
/builds/slave/m-in-lnx/build/obj-firefox/js/src/config/nsinstall -R -m 644 /builds/slave/m-in-lnx/build/js/src/../public/HashTable.h /builds/slave/m-in-lnx/build/js/src/../public/LegacyIntTypes.h /builds/slave/m-in-lnx/build/js/src/../public/MemoryMetrics.h /builds/slave/m-in-lnx/build/js/src/../public/TemplateLib.h /builds/slave/m-in-lnx/build/js/src/../public/Utility.h /builds/slave/m-in-lnx/build/js/src/../public/Vector.h ./../../dist/include/js

while a bad log:

https://tbpl.mozilla.org/php/getParsedLog.php?id=13324597&tree=Mozilla-Inbound

contains the export line:
/builds/slave/m-in-lnx/build/obj-firefox/js/src/config/nsinstall -R -m 644 /builds/slave/m-in-lnx/build/js/src/../public/HashTable.h /builds/slave/m-in-lnx/build/js/src/../public/LegacyIntTypes.h /builds/slave/m-in-lnx/build/js/src/../public/MemoryMetrics.h /builds/slave/m-in-lnx/build/js/src/../public/TemplateLib.h /builds/slave/m-in-lnx/build/js/src/../public/Utility.h /builds/slave/m-in-lnx/build/js/src/../public/Vector.h ./dist/include/js


Notice that the later export line is installing to "./dist/include/js" instead of "./../../dist/include/js".  That seems broken.

Comment 2

[Mike Hommey [:glandium]]

Likely related to bug 763987

Comment 3

[Mike Hommey [:glandium]]

So, the problem is actually very old, but before bug 763987 it wasn't really important: objdir/js/src/Makefile is created from the top directory with:
/usr/bin/perl $srcdir/build/autoconf/make-makefile -t $topsrcdir -d . js/src/Makefile

topsrcdir is thus wrong in js/src/Makefile.

Comment 4

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #3)
> topsrcdir is thus wrong in js/src/Makefile.

and DEPTH, too.

Comment 5

[Mike Hommey [:glandium]]

(In reply to Mike Hommey [:glandium] from comment #4)
> (In reply to Mike Hommey [:glandium] from comment #3)
> > topsrcdir is thus wrong in js/src/Makefile.
> 
> and DEPTH, too.

huh, no, DEPTH is hardcoded.

Comment 6

[Mike Hommey [:glandium]]

Attachment: Avoid js/src/Makefile being created with wrong topsrcdir

Comment 7

[Mike Hommey [:glandium]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/138751d54763

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/138751d54763