The default bug view has changed. See this FAQ.

adding files to js/src seems to require a clobber on tinderbox, sometimes

RESOLVED FIXED in mozilla16

Status

()

Core
Build Config
RESOLVED FIXED
5 years ago
3 years ago

People

(Reporter: luke, Assigned: glandium)

Tracking

(Blocks: 1 bug)

unspecified
mozilla16
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
Here is one example:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/c9b0e6294a7c
with log:
  https://tbpl.mozilla.org/php/getParsedLog.php?id=13324602&tree=Mozilla-Inbound&full=1

Here is another:
  https://hg.mozilla.org/integration/mozilla-inbound/rev/8417741974ba

Both involve adding files to js/src/Makefile.in that are not INSTALLED_HEADERS.

Another clue is that philor pointed out that these are the only csets to add files after bug 748001.
Comparing a good log to a failed log, one thing that seems to have gone wrong is that a good log:

https://tbpl.mozilla.org/php/getParsedLog.php?id=13317288&tree=Mozilla-Inbound

contains the export line:
/builds/slave/m-in-lnx/build/obj-firefox/js/src/config/nsinstall -R -m 644 /builds/slave/m-in-lnx/build/js/src/../public/HashTable.h /builds/slave/m-in-lnx/build/js/src/../public/LegacyIntTypes.h /builds/slave/m-in-lnx/build/js/src/../public/MemoryMetrics.h /builds/slave/m-in-lnx/build/js/src/../public/TemplateLib.h /builds/slave/m-in-lnx/build/js/src/../public/Utility.h /builds/slave/m-in-lnx/build/js/src/../public/Vector.h ./../../dist/include/js

while a bad log:

https://tbpl.mozilla.org/php/getParsedLog.php?id=13324597&tree=Mozilla-Inbound

contains the export line:
/builds/slave/m-in-lnx/build/obj-firefox/js/src/config/nsinstall -R -m 644 /builds/slave/m-in-lnx/build/js/src/../public/HashTable.h /builds/slave/m-in-lnx/build/js/src/../public/LegacyIntTypes.h /builds/slave/m-in-lnx/build/js/src/../public/MemoryMetrics.h /builds/slave/m-in-lnx/build/js/src/../public/TemplateLib.h /builds/slave/m-in-lnx/build/js/src/../public/Utility.h /builds/slave/m-in-lnx/build/js/src/../public/Vector.h ./dist/include/js


Notice that the later export line is installing to "./dist/include/js" instead of "./../../dist/include/js".  That seems broken.
(Assignee)

Comment 2

5 years ago
Likely related to bug 763987
Blocks: 763987
(Assignee)

Comment 3

5 years ago
So, the problem is actually very old, but before bug 763987 it wasn't really important: objdir/js/src/Makefile is created from the top directory with:
/usr/bin/perl $srcdir/build/autoconf/make-makefile -t $topsrcdir -d . js/src/Makefile

topsrcdir is thus wrong in js/src/Makefile.
(Assignee)

Comment 4

5 years ago
(In reply to Mike Hommey [:glandium] from comment #3)
> topsrcdir is thus wrong in js/src/Makefile.

and DEPTH, too.
(Assignee)

Comment 5

5 years ago
(In reply to Mike Hommey [:glandium] from comment #4)
> (In reply to Mike Hommey [:glandium] from comment #3)
> > topsrcdir is thus wrong in js/src/Makefile.
> 
> and DEPTH, too.

huh, no, DEPTH is hardcoded.
(Assignee)

Comment 6

5 years ago
Created attachment 640036 [details] [diff] [review]
Avoid js/src/Makefile being created with wrong topsrcdir
Attachment #640036 - Flags: review?(khuey)
Attachment #640036 - Flags: review?(khuey) → review+
(Assignee)

Updated

5 years ago
Assignee: nobody → mh+mozilla
(Assignee)

Comment 7

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/138751d54763
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/138751d54763
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
(Assignee)

Updated

5 years ago
Depends on: 775627

Updated

3 years ago
Blocks: 941904
You need to log in before you can comment on or make changes to this bug.