771896 - rm LOAD_ATOM, LOAD_NAME, and 'atoms' from js::Interpret

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Luke Wagner [:luke]]

Attachment: patch

Less macros and less local Interpret static to get wrong.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 640053 [details] [diff] [review]
patch

Review of attachment 640053 [details] [diff] [review]:
-----------------------------------------------------------------

"Bookends", eh?  ;-)

::: js/src/jsinterp.cpp
@@ +1786,5 @@
>  END_CASE(JSOP_PICK)
>  
>  BEGIN_CASE(JSOP_SETCONST)
>  {
> +    PropertyName *name = script->getName(regs.pc);

Perhaps this should use rootName0 instead?

::: js/src/jsscript.h
@@ +784,5 @@
>          return atoms[index];
>      }
>  
> +    js::HeapPtrAtom &getAtom(jsbytecode *pc) const {
> +        JS_ASSERT(pc >= code && pc < code + length);

pc + sizeof(uint32_t) < code + length seems better.

@@ +793,5 @@
>          return getAtom(index)->asPropertyName();
>      }
>  
> +    js::PropertyName *getName(jsbytecode *pc) const {
> +        JS_ASSERT(pc >= code && pc < code + length);

Id.

@@ +804,5 @@
>          return arr->vector[index];
>      }
>  
> +    JSObject *getObject(jsbytecode *pc) {
> +        JS_ASSERT(pc >= code && pc < code + length);

Id.

Comment 2

[Luke Wagner [:luke]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/5645ad3abc2c

Comment 3

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/5645ad3abc2c