Note: There are a few cases of duplicates in user autocompletion which are being worked on.

rm LOAD_ATOM, LOAD_NAME, and 'atoms' from js::Interpret

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: luke, Assigned: luke)

Tracking

unspecified
mozilla16
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 640053 [details] [diff] [review]
patch

Less macros and less local Interpret static to get wrong.
Attachment #640053 - Flags: review?(jwalden+bmo)
Comment on attachment 640053 [details] [diff] [review]
patch

Review of attachment 640053 [details] [diff] [review]:
-----------------------------------------------------------------

"Bookends", eh?  ;-)

::: js/src/jsinterp.cpp
@@ +1786,5 @@
>  END_CASE(JSOP_PICK)
>  
>  BEGIN_CASE(JSOP_SETCONST)
>  {
> +    PropertyName *name = script->getName(regs.pc);

Perhaps this should use rootName0 instead?

::: js/src/jsscript.h
@@ +784,5 @@
>          return atoms[index];
>      }
>  
> +    js::HeapPtrAtom &getAtom(jsbytecode *pc) const {
> +        JS_ASSERT(pc >= code && pc < code + length);

pc + sizeof(uint32_t) < code + length seems better.

@@ +793,5 @@
>          return getAtom(index)->asPropertyName();
>      }
>  
> +    js::PropertyName *getName(jsbytecode *pc) const {
> +        JS_ASSERT(pc >= code && pc < code + length);

Id.

@@ +804,5 @@
>          return arr->vector[index];
>      }
>  
> +    JSObject *getObject(jsbytecode *pc) {
> +        JS_ASSERT(pc >= code && pc < code + length);

Id.
Attachment #640053 - Flags: review?(jwalden+bmo) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/5645ad3abc2c
Target Milestone: --- → mozilla16
Whiteboard: [js:t]
https://hg.mozilla.org/mozilla-central/rev/5645ad3abc2c
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.