Get rid of Wrapper::leave

RESOLVED FIXED

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: ejpbruel, Assigned: ejpbruel)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [js:t])

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Our policy enforcement mechanism for wrappers currently consists of a single call to Wrapper::enter, followed by a single call to Wrapper::leave. The latter call, however, is strictly unnecessary, since every implementation of it is currently empty. There is no reason to assume that this will change anytime soon, so we might as well get rid of this superfluous call.
(Assignee)

Comment 1

5 years ago
Created attachment 640240 [details] [diff] [review]
Patch to be reviewed
Attachment #640240 - Flags: review?(bobbyholley+bmo)
Comment on attachment 640240 [details] [diff] [review]
Patch to be reviewed

r=bholley. But let's just double-check to make sure mrbkap is ok with it.
Attachment #640240 - Flags: superreview?(mrbkap)
Attachment #640240 - Flags: review?(bobbyholley+bmo)
Attachment #640240 - Flags: review+
(Assignee)

Updated

5 years ago
Blocks: 772138
Whiteboard: [js:t]

Updated

5 years ago
Attachment #640240 - Flags: superreview?(mrbkap) → superreview+
(Assignee)

Comment 3

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba89d552b9dc
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
https://hg.mozilla.org/mozilla-central/rev/ba89d552b9dc

Updated

5 years ago
Depends on: 773962

Updated

5 years ago
No longer depends on: 773962
You need to log in before you can comment on or make changes to this bug.