Closed Bug 771908 Opened 12 years ago Closed 12 years ago

Get rid of Wrapper::leave

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: ejpbruel, Assigned: ejpbruel)

References

Details

(Whiteboard: [js:t])

Attachments

(1 file)

Patch to be reviewed
9.58 KB, patch
bholley
: review+
mrbkap
: superreview+
Details | Diff | Splinter Review 
Our policy enforcement mechanism for wrappers currently consists of a single call to Wrapper::enter, followed by a single call to Wrapper::leave. The latter call, however, is strictly unnecessary, since every implementation of it is currently empty. There is no reason to assume that this will change anytime soon, so we might as well get rid of this superfluous call.

        Attachment #640240 -
        Flags: review?(bobbyholley+bmo)

    
    

    
  
Comment on attachment 640240 [details] [diff] [review]
Patch to be reviewed

r=bholley. But let's just double-check to make sure mrbkap is ok with it.

        Attachment #640240 -
        Flags: superreview?(mrbkap)

        Attachment #640240 -
        Flags: review?(bobbyholley+bmo)

        Attachment #640240 -
        Flags: review+

    
  
Blocks: 772138
Whiteboard: [js:t]

        Attachment #640240 -
        Flags: superreview?(mrbkap) → superreview+

    
    

    
  
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba89d552b9dc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED

    
  
Depends on: 773962

    
  
No longer depends on: 773962

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: