Closed Bug 771925 Opened 13 years ago Closed 13 years ago

Extra semicolon warnings (-Werror, -Wextra-semi)

Categories

(Core :: General, defect)

Product:
Core
Component:
General
Type:
defect
Priority:
Not set
Severity:
minor

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: nical, Unassigned)

Details

Attachments

(5 obsolete files)

I just switched from gcc to clang, and with my config having "ac_add_options --enable-warnings-as-errors", I see a lot of extra semicolons warning (which become errors with my mozconfig). These warnings are in most cases very easy to fix, I propose that we fix as many as we can in this bug.
I start with a bunch of these warnings from GLContext.h At the same time I am moving from hg to git, so I hope the patch is forwatted correctly.
Attachment #640098 - Flags: review?(jmuizelaar)
Comment on attachment 640098 [details] [diff] [review] Fixes extra semicolons after function definitions in GLContext.h and GLContextProviderGLX.cpp Looks like the patch is backwards, but otherwise looks fine to me
Attachment #640098 - Flags: review?(jmuizelaar) → review+
fixed the patch formatting
Attachment #640098 - Attachment is obsolete: true
Attachment #643233 - Flags: checkin?(jmuizelaar)
Comment on attachment 643233 [details] [diff] [review] Fixes extra semicolons after function definitions in GLContext.h and GLContextProviderGLX.cpp It looks like someone fixed it in another bug
Attachment #643233 - Attachment is obsolete: true
Attachment #643233 - Flags: checkin?(jmuizelaar)
Comment on attachment 640105 [details] [diff] [review] Fixes extra semicolons after function definitions in various files. It looks like someone fixed it in another bug
Attachment #640105 - Attachment is obsolete: true
Comment on attachment 640103 [details] [diff] [review] Fixes extra semicolons after function definitions in SVGAnimatedPreserveAspectRatio.h. It looks like someone fixed it in another bug
Comment on attachment 640103 [details] [diff] [review] Fixes extra semicolons after function definitions in SVGAnimatedPreserveAspectRatio.h. It looks like someone fixed it in another bug
Attachment #640103 - Attachment is obsolete: true
Attachment #640101 - Attachment is obsolete: true
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: