771946 - "Assertion failure: ToInteger(year) == year," or "Assertion failure: ToInteger(date) == date," or "Assertion failure: ToInteger(month) == month,"

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Attachment: stack

Date.prototype.setFullYear(Math.cos(1))

asserts js debug shell on m-c changeset 221f1a184f67 without any CLI arguments at Assertion failure: ToInteger(year) == year,

autoBisect shows this is probably related to the following changeset:

The first bad revision is:
changeset:   98627:e68d62b3ab83
user:        Jeff Walden
date:        Fri Jul 06 13:53:11 2012 -0700
summary:     Bug 771742 - Reimplement the Date.prototype.set<date component> functions in terms of their spec steps, and remove the hard-to-understand date_makeDate.  r=luke

Comment 1

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Date.prototype.setUTCDate(Math.tan(1))

asserts at a similar assertion:

Assertion failure: ToInteger(date) == date,

Comment 2

[Jesse Ruderman]

No need for trig functions. You can substitute the value and still assert:

Date.prototype.setUTCDate(1.5)

Comment 3

[Gary Kwong [:gkw] [:nth10sd] (NOT official MoCo now)]

Date.prototype.setMonth(1.5)

Assertion failure: ToInteger(month) == month,

Comment 4

[Jeff Walden [:Waldo]]

Attachment: Convert most date spec methods to take, produce doubles

I don't know how we managed to avoid all the intermediate checking before, at least not without being buggy in boundary cases.  But I think this covers everything.

Comment 5

[Luke Wagner [:luke]]

Comment on attachment 640359 [details] [diff] [review]
Convert most date spec methods to take, produce doubles

Goofy

Comment 6

[Jeff Walden [:Waldo]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/57e0bdd6f6c7

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/57e0bdd6f6c7

Comment 8

[Christian Holler (:decoder)]

Automatically extracted testcase for this bug was committed:

https://hg.mozilla.org/mozilla-central/rev/efaf8960a929