Closed Bug 771963 Opened 14 years ago Closed 12 years ago

devicemanagerSUT.py installApp returns None for failure AND success

Categories

(Testing :: General, defect)

Product:
Testing
Component:
General
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED INVALID

People

(Reporter: Callek, Unassigned)

References

Details

In trying to identify issues with installApp when run from a windows system, I learned that deviceManagerSUT.installApp(...) can return None in failure *AND* success modes, see the code in: http://mxr.mozilla.org/mozilla-central/source/build/mobile/devicemanagerSUT.py#967 The hard part with fixing this is to audit all callers and ensure we handle the cases right in all places.
My fix to bug 792072 should magically take care of this, by changing installApp to throw an exception in case of error. I believe sut_tools and eideticker are the only current users of this API. Doing a search of installApp in mxr does not turn anything up.
Depends on: 792072
Since we now throw exceptions in case of error, this no longer applies.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → INVALID
Component: New Frameworks → General
You need to log in before you can comment on or make changes to this bug.