All users were logged out of Bugzilla on October 13th, 2018

devicemanagerSUT.py installApp returns None for failure AND success

RESOLVED INVALID

Status

RESOLVED INVALID
6 years ago
9 months ago

People

(Reporter: Callek, Unassigned)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Reporter)

Description

6 years ago
In trying to identify issues with installApp when run from a windows system, I learned that deviceManagerSUT.installApp(...) can return None in failure *AND* success modes, see the code in:

http://mxr.mozilla.org/mozilla-central/source/build/mobile/devicemanagerSUT.py#967

The hard part with fixing this is to audit all callers and ensure we handle the cases right in all places.
My fix to bug 792072 should magically take care of this, by changing installApp to throw an exception in case of error.

I believe sut_tools and eideticker are the only current users of this API. Doing a search of installApp in mxr does not turn anything up.
Depends on: 792072
Since we now throw exceptions in case of error, this no longer applies.
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → INVALID
(Assignee)

Updated

9 months ago
Component: New Frameworks → General
Product: Testing → Testing
You need to log in before you can comment on or make changes to this bug.