771989 - Virtual keyboard is dismissed when in Find in Page highlights a link

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Keyboards and IME, defect)

Description

[Adrian Tamas (:AdrianT)]

Attachment: logs

This is a follow-up bug for bug 760087

Nightly 16.0a1 2012-07-08/ Aurora 15.0a2 2012-07-08
Device: Google Nexus(Android 4.0.2), HTC Desire(Android 2.2.2)

Steps to reproduce:
1. Go to neowin.com.
2. Open the menu and select "find in page".
3. Start typing "windows".

Expected results:
The user can perform a search.

Actual results:
When "w" is typed the vkb is dismissed. Whenever the highlight is moved to another word the virtual keyboard is dismissed again.

Notes:
Please see the videocapture: http://youtu.be/YY2yitQh8nU

Comment 1

[Aaron Train [:aaronmt]]

We're not using the blocking-flag anymore.

Comment 2

[Aaron Train [:aaronmt]]

Matt, thoughts?

Comment 3

[Matt Brubeck (:mbrubeck)]

I'll take a look...

Comment 4

[Matt Brubeck (:mbrubeck)]

I don't see anything obvious; the focus does not seem to be stolen in the same way it was in bug 760087.  If someone has time to bisect this, it would be useful to know a regression range.

Comment 5

[Matt Brubeck (:mbrubeck)]

I can't reproduce this on Aurora (15.0a2).

Comment 6

[Peter Retzer (:pretzer)]

I can reproduce with latest Nightly 16.0a1 (2012-07-12) on Galaxy S2 (Android 4.0.3) if that helps.

Comment 7

[Matt Brubeck (:mbrubeck)]

I can reproduce this on Aurora now.

Comment 9

[Matt Brubeck (:mbrubeck)]

I was having trouble reproducing this before because (unlike in bug 760087), this happens only when the highlighted match is a link.  So whether the bug occurs depends on the content.  It looks like this is not a new regression; it was just uncovered when bug 760087 was fixed.

Comment 10

[Matt Brubeck (:mbrubeck)]

Attachment: patch

GeckoInputConnection calls hideSoftInputFromWindow in response to reset messages from Gecko -- even if some other view like the Find In Page bar is in focus.  With this patch, it will hide the keyboard only if the Gecko view has the input focus.

Comment 11

[Matt Brubeck (:mbrubeck)]

Attachment: patch

I uploaded the wrong patch, obviously.

Comment 12

[Chris Peterson [:cpeterson]]

Comment on attachment 642748 [details] [diff] [review]
patch

Review of attachment 642748 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

Comment 13

[Matt Brubeck (:mbrubeck)]

Comment on attachment 642748 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): New Fx15 "Find In Page" feature (bug 695172)

User impact if declined: Find In Page is hard to use because the keyboard disappears unpredictably while you are typing.

Testing completed (on m-c, etc.): Landed on inbound 7/16.

Risk to taking this patch (and alternatives if risky): This is a very low-risk one line Android-only patch.  It just stops us from hiding the keyboard in one specific condition.

String or UUID changes made by this patch: None.

https://hg.mozilla.org/integration/mozilla-inbound/rev/93c10b4845d2

Comment 14

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/93c10b4845d2

Comment 15

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 642748 [details] [diff] [review]
patch

[Triage Comment]
This is low risk and landing in plenty of time for verification.  Approving.

Comment 16

[Matt Brubeck (:mbrubeck)]

https://hg.mozilla.org/releases/mozilla-beta/rev/97a2af80999b
https://hg.mozilla.org/releases/mozilla-aurora/rev/1424be157414