772036 - Unit test failure: *ListView click handler

Status: RESOLVED FIXED

(Pancake Graveyard :: Front-end, defect)

Description

[Sam Foster [:sfoster] (he/him)]

The following assertions fail: 

should trigger a visit event when clicked
Expected spy unknown to have been called.

should pass view, StackModel and DOM event to the handler
TypeError: 'undefined' is not an object (evaluating 'args[0]') in http://colin.local:6543/test/spec/StackListViewSpec.js?v=1.1 (line 77)

..check these specs reflect current expectations and fix/remove/amend.

Comment 1

[Sam Foster [:sfoster] (he/him)]

Looks like similar issues with StackHeadingListView click handler, StackHeadingListView title click handler, PostListView touchend/click handler

Comment 2

[Sam Foster [:sfoster] (he/him)]

I have the first of these fixed in https://bitbucket.org/mozillapancake/pancake/changeset/b29a9eb0549d
These are old test failures due to some quirk in how $.trigger works in zepto maybe? I've reworked them to avoid the faux DOM events and test the rendering is what we expect, and that we get the expected result when our click handler is called with an event-like thing; we know event handling/delegation works so that doesn't need to be under test.

Comment 3

[Sam Foster [:sfoster] (he/him)]

PostViewView specs and StackHeadingListView specs reworked and now passing in Safari. 

See: 
https://bitbucket.org/mozillapancake/pancake/changeset/99c71be4b96f
https://bitbucket.org/mozillapancake/pancake/changeset/bfadb054d7d0
https://bitbucket.org/mozillapancake/pancake/changeset/b29a9eb0549d