772105 - Should give a better error if failed to push a file with devicemanagerSUT

Status: RESOLVED FIXED

(Testing :: General, defect)

Description

[William Lachance (:wlach)]

Right now we return the following (not descriptive) error if we fail to push a file with devicemanagerSUT:

Push File Failed to Validate!

We actually do have the necessary information to give a descriptive error message when this fails (for instance, if the disk was full), so let's do that instead.

Comment 1

[William Lachance (:wlach)]

Attachment: Patch to improve error message

Here's a patch which implements the suggested behaviour (a try run has been queued to verify that it doesn't break anything). Now when you try to push on a device with a full sdcard, you get the following error:

error pushing file: Agent Error processing command 'push /mnt/sdcard/init.py 363'; err='Push failed!'

It would be even better if we modified the agent to give a more explicit error here, but this is a good start.

This patch also changes the way we handle commands. Commands now can optionally specify "data" attached to them, instead of (confusingly) treating data as a special case command. This was necessary to get the right behaviour, but seems more straightforward to me in general.

Comment 2

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 640309 [details] [diff] [review]
Patch to improve error message

Review of attachment 640309 [details] [diff] [review]:
-----------------------------------------------------------------

nice.  Took me 2 passes through this to figure out what was happening.

Comment 3

[William Lachance (:wlach)]

Attachment: Fix some problems with previous patch

This fixes a problem in the way we called sendCmds from shell(), but is otherwise the same as the previous patch.

Carrying over r+

Comment 4

[William Lachance (:wlach)]

Try run looks good with updated patch: https://tbpl.mozilla.org/?tree=Try&rev=e237e4112e24

Comment 5

[William Lachance (:wlach)]

Inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/a667224e0861

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/a667224e0861