Closed Bug 772105 Opened 8 years ago Closed 8 years ago

Should give a better error if failed to push a file with devicemanagerSUT

Categories

(Testing :: General, defect)

ARM
Android
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla16

People

(Reporter: wlach, Assigned: wlach)

Details

Attachments

(1 file, 1 obsolete file)

Right now we return the following (not descriptive) error if we fail to push a file with devicemanagerSUT:

Push File Failed to Validate!

We actually do have the necessary information to give a descriptive error message when this fails (for instance, if the disk was full), so let's do that instead.
Attached patch Patch to improve error message (obsolete) — Splinter Review
Here's a patch which implements the suggested behaviour (a try run has been queued to verify that it doesn't break anything). Now when you try to push on a device with a full sdcard, you get the following error:

error pushing file: Agent Error processing command 'push /mnt/sdcard/init.py 363'; err='Push failed!'

It would be even better if we modified the agent to give a more explicit error here, but this is a good start.

This patch also changes the way we handle commands. Commands now can optionally specify "data" attached to them, instead of (confusingly) treating data as a special case command. This was necessary to get the right behaviour, but seems more straightforward to me in general.
Assignee: nobody → wlachance
Attachment #640309 - Flags: review?(jmaher)
Comment on attachment 640309 [details] [diff] [review]
Patch to improve error message

Review of attachment 640309 [details] [diff] [review]:
-----------------------------------------------------------------

nice.  Took me 2 passes through this to figure out what was happening.
Attachment #640309 - Flags: review?(jmaher) → review+
This fixes a problem in the way we called sendCmds from shell(), but is otherwise the same as the previous patch.

Carrying over r+
Attachment #640309 - Attachment is obsolete: true
Attachment #641039 - Flags: review+
https://hg.mozilla.org/mozilla-central/rev/a667224e0861
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.