77211 - filter migration saves file in wrong location

Status: VERIFIED FIXED

(Core Graveyard :: Profile: Migration, defect, P2)

Description

[Derek Price]

The conversoin of Netscape setup files leaves the filter configuration file in
~/.mozilla but the mail app seems to be looking for it somewhere under
~/.mozilla/<username>/<garble>/Mail...

Comment 1

[Boris Zbarsky [:bzbarsky]]

over to profile migration

Comment 2

[laurel]

I just tried IMAP, works fine with Apr23 build, linux rh6.2. Will double-check
POP shortly, as that's what you indicate went wrong.

Comment 3

[laurel]

Yes, POP is going awry.  It didn't put rules.dat in the wrong place when I
tried, but it was empty.  No other rules.dat around in other directories, just
didn't complete the migration of the rules. cc sspitzer

Comment 4

[laurel]

Subsequent tries on linux resulted in the same thing -- old mailrule file is in
the <garble> directory.  No rules.dat excepting in the correct Mail/<server>
directory, but it is 25 bytes, which is just the default header info and no
rules copied from old mailrule file.  Cannot locate any other rules.dat anywhere
in the .mozilla structure.

Comment 5

[laurel]

Happening on all platforms, POP only.
I know I saw filters migrate OK on mac within the last week or so.  Something
broke this recently.

Comment 6

[(not reading, please use [e-mail] instead)]

not sure what's going on here, but there were some profile changes recently.

(not assigning blame, just adding that info.)

Comment 7

[scottputterman]

marking nsbeta1+

Comment 8

[scottputterman]

reassigning to cavin

Comment 9

[(not reading, please use [e-mail] instead)]

I'm seeing this with pop on mac.

I think cavin's fix for #66018 will fix this, rebuilding with his patch on mac 
now to confirm that.

I'll be trying his patch on linux tomorrow.  there's enough platform specific 
code in migration that requires this to be tested on all 3 before we can claim 
victory.

 

Comment 10

[(not reading, please use [e-mail] instead)]

cavin's fix fixes this problem for me on the mac.

we'll know about linux tomorrow.

Comment 11

[(not reading, please use [e-mail] instead)]

fixed.

Comment 12

[(not reading, please use [e-mail] instead)]

some information:

this was not fixed by cavin's fix for #66018, it was fixed by his fix for #50567

the problem was this:

the pref migration code was creating ~/.mozilla/foo/bar.slt/Mail/Mail/mail.meer.net
but the code to copy the mailrule (that was the 4.x name for the filters file)
was trying to copy it into ~/.mozilla/foo.bar.slt/Mail/mail.meer.net/rules.dat

~/.mozilla/foo.bar.slt/Mail/mail.meer.net did not exist, so the copy failed
silently.  when I checked in cavin's fix for #50567, it fixed the problem.

I added some assertions to nsPrefMigration.cpp to assert (but continue on) when 
CopyToDir() fails.

Comment 13

[laurel]

OK using commercial builds:
2001-05-23-04 win98
2001-05-23-08 mac OS 9.0
2001-05-23-08 linux rh6.2