772201 - Webrtc breaks builds with symlinked objdirs

Status: RESOLVED FIXED

Description

[Randell Jesup [:jesup] (needinfo me)]

The assumption is that this is due to use of relative paths to try to get 'out' of the objdir.  Likely the problem is largely in mozmake.py; perhaps in configure.in, media/webrtc/Makefile.in or related spots.

Comment 1

[Randell Jesup [:jesup] (needinfo me)]

Attachment: remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs

Comment 2

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 640497 [details] [diff] [review]
remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs

This appears to fix all the ../* paths in topsrcdir/srcdir/VPATH in gyp-generated Makefiles.

A grep on the makefiles showed no relative paths left after applying this patch and generating an objdir through a symlink, and it builds.

Comment 3

[Jason Duell]

Comment on attachment 640497 [details] [diff] [review]
remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs

Review of attachment 640497 [details] [diff] [review]:
-----------------------------------------------------------------

Fixes the bustage for me.  Thanks Randell!

Comment 4

[Karsten Düsterloh]

FWIW: my Linux 64 bit SeaMonkey debug builds are also affected by this bug and this patch does help indeed.

Comment 5

[Randell Jesup [:jesup] (needinfo me)]

Attachment: remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs (2)

Comment 6

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 641185 [details] [diff] [review]
remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs (2)

Uses OS to decide to do absolute paths or not (always relative on windows to make it work with 'make' as well as 'pymake').

I'll fix the missing space in the first change before checkin

Comment 7

[Randell Jesup [:jesup] (needinfo me)]

All green on try!  https://tbpl.mozilla.org/?tree=Try&pusher=[e-mail]

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 641185 [details] [diff] [review]
remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs (2)

Review of attachment 641185 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.py
@@ +197,5 @@
>  def Compilable(filename):
>    return os.path.splitext(filename)[1] in COMPILABLE_EXTENSIONS
>  
>  class MakefileGenerator(object):
> +  def __init__(self, target_dicts, data, options, depth, topsrcdir, relative_topsrcdir, relative_srcdir, output_dir,flavor):

nit: space after the comma

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

nit fixed
https://hg.mozilla.org/integration/mozilla-inbound/rev/641d061b9e19

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/641d061b9e19