Closed
Bug 772201
Opened 10 years ago
Closed 10 years ago
Webrtc breaks builds with symlinked objdirs
Categories
(Core :: WebRTC, defect)
Core
WebRTC
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: jesup, Assigned: jesup)
Details
(Whiteboard: [qa-])
Attachments
(1 file, 1 obsolete file)
The assumption is that this is due to use of relative paths to try to get 'out' of the objdir. Likely the problem is largely in mozmake.py; perhaps in configure.in, media/webrtc/Makefile.in or related spots.
Assignee | ||
Comment 1•10 years ago
|
||
Assignee | ||
Comment 2•10 years ago
|
||
Comment on attachment 640497 [details] [diff] [review] remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs This appears to fix all the ../* paths in topsrcdir/srcdir/VPATH in gyp-generated Makefiles. A grep on the makefiles showed no relative paths left after applying this patch and generating an objdir through a symlink, and it builds.
Attachment #640497 -
Flags: review?(ted.mielczarek)
Comment 3•10 years ago
|
||
Comment on attachment 640497 [details] [diff] [review] remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs Review of attachment 640497 [details] [diff] [review]: ----------------------------------------------------------------- Fixes the bustage for me. Thanks Randell!
Attachment #640497 -
Flags: feedback+
Comment 4•10 years ago
|
||
FWIW: my Linux 64 bit SeaMonkey debug builds are also affected by this bug and this patch does help indeed.
Assignee | ||
Comment 5•10 years ago
|
||
Assignee | ||
Updated•10 years ago
|
Attachment #640497 -
Attachment is obsolete: true
Attachment #640497 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 6•10 years ago
|
||
Comment on attachment 641185 [details] [diff] [review] remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs (2) Uses OS to decide to do absolute paths or not (always relative on windows to make it work with 'make' as well as 'pymake'). I'll fix the missing space in the first change before checkin
Attachment #641185 -
Flags: review?(ted.mielczarek)
Assignee | ||
Comment 7•10 years ago
|
||
All green on try! https://tbpl.mozilla.org/?tree=Try&pusher=rjesup@wgate.com
Comment 8•10 years ago
|
||
Comment on attachment 641185 [details] [diff] [review] remove relative topsrcdir/srcdir/etc paths from gyp-sourced Makefiles - fixes symlinked objdirs (2) Review of attachment 641185 [details] [diff] [review]: ----------------------------------------------------------------- ::: media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.py @@ +197,5 @@ > def Compilable(filename): > return os.path.splitext(filename)[1] in COMPILABLE_EXTENSIONS > > class MakefileGenerator(object): > + def __init__(self, target_dicts, data, options, depth, topsrcdir, relative_topsrcdir, relative_srcdir, output_dir,flavor): nit: space after the comma
Attachment #641185 -
Flags: review?(ted.mielczarek) → review+
Assignee | ||
Comment 9•10 years ago
|
||
nit fixed https://hg.mozilla.org/integration/mozilla-inbound/rev/641d061b9e19
Comment 10•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/641d061b9e19
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
Updated•10 years ago
|
Whiteboard: [qa-]
You need to log in
before you can comment on or make changes to this bug.
Description
•