772202 - fix dom/imptests/importTestsuite.py to not introduce libs:: rules

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nathan Froyd [:froydnj]]

Bug 370750 erroneously(?) modified a bunch of makefiles that were generated by importTestsuite.py.  The script itself should be fixed so that future imports don't introduce more libs:: rules.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

Comment 2

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 640342 [details] [diff] [review]
patch

Review of attachment 640342 [details] [diff] [review]:
-----------------------------------------------------------------

This code now lives in <http://mxr.mozilla.org/mozilla-central/source/dom/imptests/writeMakefile.py>; r=me if you use ':=' instead of '=' for the assignment.

Comment 3

[Nathan Froyd [:froydnj]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7bd28eb29f44

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7bd28eb29f44

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

I missed that we now don't always include rules.mk. Patch coming up.

Comment 6

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Attachment: Patch

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This was fixed at some point?