Closed
Bug 772202
Opened 13 years ago
Closed 12 years ago
fix dom/imptests/importTestsuite.py to not introduce libs:: rules
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: froydnj, Assigned: froydnj)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
|
1.06 KB,
patch
|
Ms2ger
:
review+
|
Details | Diff | Splinter Review |
|
17.81 KB,
patch
|
k0scist
:
review+
|
Details | Diff | Splinter Review |
Bug 370750 erroneously(?) modified a bunch of makefiles that were generated by importTestsuite.py. The script itself should be fixed so that future imports don't introduce more libs:: rules.
|
Assignee | |
Comment 1•13 years ago
|
||
Attachment #640342 -
Flags: review?(Ms2ger)
|
||
Updated•13 years ago
|
Blocks: nomakerules
|
||
Comment 2•13 years ago
|
||
Comment on attachment 640342 [details] [diff] [review]
patch
Review of attachment 640342 [details] [diff] [review]:
-----------------------------------------------------------------
This code now lives in <http://mxr.mozilla.org/mozilla-central/source/dom/imptests/writeMakefile.py>; r=me if you use ':=' instead of '=' for the assignment.
Attachment #640342 -
Flags: review?(Ms2ger) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Assignee: nobody → nfroyd
Status: NEW → ASSIGNED
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
|
|
||
Comment 5•13 years ago
|
||
I missed that we now don't always include rules.mk. Patch coming up.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
|
|
||
Comment 6•13 years ago
|
||
Attachment #645714 -
Flags: review?(jhammel)
|
||
Updated•13 years ago
|
Attachment #645714 -
Flags: review?(jhammel) → review+
|
|
||
Comment 7•12 years ago
|
||
This was fixed at some point?
Status: REOPENED → RESOLVED
Closed: 13 years ago → 12 years ago
Resolution: --- → FIXED
|
||
Updated•6 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•