Fix warning: unused variable 'initFlushCount'

RESOLVED FIXED in Firefox 16

Status

()

Core
JavaScript Engine
--
minor
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: cpeterson, Assigned: cpeterson)

Tracking

Trunk
mozilla16
ARM
Android
Points:
---

Firefox Tracking Flags

(firefox16 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
When building for Android/JS_CPU_ARM, I see many instances of the following compiler warning because BaseAssembler.h is #included in many other files:

mozilla/inbound/js/src/methodjit/BaseAssembler.h: In member function 'JSC::AbstractMacroAssembler<JSC::ARMAssembler>::Call js::mjit::Assembler::callWithABI(void*, bool)':
mozilla/inbound/js/src/methodjit/BaseAssembler.h:563: warning: unused variable 'initFlushCount'
(Assignee)

Updated

5 years ago
Assignee: general → cpeterson
Severity: normal → minor
Status: NEW → ASSIGNED
status-firefox16: --- → affected
Summary: Fix debug warning: unused variable 'initFlushCount' → Fix warning: unused variable 'initFlushCount'
(Assignee)

Comment 1

5 years ago
Created attachment 640350 [details] [diff] [review]
fix-initFlushCount-warning.patch

Fix warning: unused variable 'initFlushCount' by using DebugOnly<int>. This code only affects #ifdef JS_CPU_ARM builds.
Attachment #640350 - Flags: review?(luke)

Updated

5 years ago
Attachment #640350 - Flags: review?(luke) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/c5623d48b5fc
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
status-firefox16: affected → fixed
Resolution: --- → FIXED
Don't resolve bugs until they land on m-c.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
https://hg.mozilla.org/mozilla-central/rev/c5623d48b5fc
Status: REOPENED → RESOLVED
Last Resolved: 5 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.