Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Password mask timer is too short on Android

RESOLVED FIXED in mozilla16

Status

()

Core
Editor
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: m_kato, Assigned: m_kato)

Tracking

Trunk
mozilla16
All
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Since LookAndFeel::GetEchoPassword() returns true, editor masks password by one short timer.  On TextView of android framework, this timer is 1.5 sec.  but Gecko uses 0.6 sec now. (from Maemo?)

This value should be platform specific.
Moving into Fennec to get the attention of the right people.  But yeah, this makes sense to me.
Component: Editor → General
Product: Core → Firefox for Android
(Assignee)

Comment 2

5 years ago
Created attachment 640948 [details] [diff] [review]
fix
Assignee: nobody → m_kato
(Assignee)

Updated

5 years ago
Attachment #640948 - Flags: review?(blassey.bugs)
(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> Moving into Fennec to get the attention of the right people.  But yeah, this
> makes sense to me.

Fwiw... I'd rather bugs stay in the "right" component for the code they touch rather than fall into the Fennec product bucket. The best way to get our attention on a bug is to request tracking-fennec.
Comment on attachment 640948 [details] [diff] [review]
fix

Review of attachment 640948 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/nsLookAndFeel.cpp
@@ +476,5 @@
> +PRUint32
> +nsLookAndFeel::GetPasswordMaskDelayImpl()
> +{
> +  // This value is hard-coded in PasswordTransformationMethod.java
> +  return 1500;

ugh... I really wish this was query-able, but such is life
Attachment #640948 - Flags: review?(blassey.bugs) → review+
(In reply to Brad Lassey [:blassey] from comment #3)
> (In reply to Ehsan Akhgari [:ehsan] from comment #1)
> > Moving into Fennec to get the attention of the right people.  But yeah, this
> > makes sense to me.
> 
> Fwiw... I'd rather bugs stay in the "right" component for the code they
> touch rather than fall into the Fennec product bucket. The best way to get
> our attention on a bug is to request tracking-fennec.

Good point.  Moving back to editor, and thanks for bringing my attention to tracking-fennec.  :-)
tracking-fennec: --- → ?
Component: General → Editor
Product: Firefox for Android → Core
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/b303b2565fe6
Target Milestone: --- → mozilla16

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/b303b2565fe6
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
tracking-fennec: ? → ---
You need to log in before you can comment on or make changes to this bug.