Last Comment Bug 772327 - Password mask timer is too short on Android
: Password mask timer is too short on Android
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All Android
: -- normal (vote)
: mozilla16
Assigned To: Makoto Kato [:m_kato]
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-09 20:06 PDT by Makoto Kato [:m_kato]
Modified: 2013-12-10 10:01 PST (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
fix (4.38 KB, patch)
2012-07-10 23:50 PDT, Makoto Kato [:m_kato]
blassey.bugs: review+
Details | Diff | Splinter Review

Description Makoto Kato [:m_kato] 2012-07-09 20:06:00 PDT
Since LookAndFeel::GetEchoPassword() returns true, editor masks password by one short timer.  On TextView of android framework, this timer is 1.5 sec.  but Gecko uses 0.6 sec now. (from Maemo?)

This value should be platform specific.
Comment 1 :Ehsan Akhgari 2012-07-10 13:24:31 PDT
Moving into Fennec to get the attention of the right people.  But yeah, this makes sense to me.
Comment 2 Makoto Kato [:m_kato] 2012-07-10 23:50:03 PDT
Created attachment 640948 [details] [diff] [review]
fix
Comment 3 Brad Lassey [:blassey] (use needinfo?) 2012-07-11 05:40:44 PDT
(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> Moving into Fennec to get the attention of the right people.  But yeah, this
> makes sense to me.

Fwiw... I'd rather bugs stay in the "right" component for the code they touch rather than fall into the Fennec product bucket. The best way to get our attention on a bug is to request tracking-fennec.
Comment 4 Brad Lassey [:blassey] (use needinfo?) 2012-07-11 05:43:28 PDT
Comment on attachment 640948 [details] [diff] [review]
fix

Review of attachment 640948 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/nsLookAndFeel.cpp
@@ +476,5 @@
> +PRUint32
> +nsLookAndFeel::GetPasswordMaskDelayImpl()
> +{
> +  // This value is hard-coded in PasswordTransformationMethod.java
> +  return 1500;

ugh... I really wish this was query-able, but such is life
Comment 5 :Ehsan Akhgari 2012-07-11 21:44:20 PDT
(In reply to Brad Lassey [:blassey] from comment #3)
> (In reply to Ehsan Akhgari [:ehsan] from comment #1)
> > Moving into Fennec to get the attention of the right people.  But yeah, this
> > makes sense to me.
> 
> Fwiw... I'd rather bugs stay in the "right" component for the code they
> touch rather than fall into the Fennec product bucket. The best way to get
> our attention on a bug is to request tracking-fennec.

Good point.  Moving back to editor, and thanks for bringing my attention to tracking-fennec.  :-)
Comment 7 Ed Morley [:emorley] 2012-07-13 05:29:59 PDT
https://hg.mozilla.org/mozilla-central/rev/b303b2565fe6

Note You need to log in before you can comment on or make changes to this bug.