772327 - Password mask timer is too short on Android

Status: RESOLVED FIXED

(Core :: DOM: Editor, defect)

Description

[Makoto Kato [:m_kato]]

Since LookAndFeel::GetEchoPassword() returns true, editor masks password by one short timer.  On TextView of android framework, this timer is 1.5 sec.  but Gecko uses 0.6 sec now. (from Maemo?)

This value should be platform specific.

Comment 1

[(no longer active)]

Moving into Fennec to get the attention of the right people.  But yeah, this makes sense to me.

Comment 2

[Makoto Kato [:m_kato]]

Attachment: fix

Comment 3

[Brad Lassey [:blassey] (use needinfo?)]

(In reply to Ehsan Akhgari [:ehsan] from comment #1)
> Moving into Fennec to get the attention of the right people.  But yeah, this
> makes sense to me.

Fwiw... I'd rather bugs stay in the "right" component for the code they touch rather than fall into the Fennec product bucket. The best way to get our attention on a bug is to request tracking-fennec.

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 640948 [details] [diff] [review]
fix

Review of attachment 640948 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/android/nsLookAndFeel.cpp
@@ +476,5 @@
> +PRUint32
> +nsLookAndFeel::GetPasswordMaskDelayImpl()
> +{
> +  // This value is hard-coded in PasswordTransformationMethod.java
> +  return 1500;

ugh... I really wish this was query-able, but such is life

Comment 5

[(no longer active)]

(In reply to Brad Lassey [:blassey] from comment #3)
> (In reply to Ehsan Akhgari [:ehsan] from comment #1)
> > Moving into Fennec to get the attention of the right people.  But yeah, this
> > makes sense to me.
> 
> Fwiw... I'd rather bugs stay in the "right" component for the code they
> touch rather than fall into the Fennec product bucket. The best way to get
> our attention on a bug is to request tracking-fennec.

Good point.  Moving back to editor, and thanks for bringing my attention to tracking-fennec.  :-)

Comment 6

[Makoto Kato [:m_kato]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b303b2565fe6

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b303b2565fe6