772449 - VKB is not dismissed when up/down arrows are tapped for Find in Page

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Firefox 16.0a1 (2012-07-10)
Device: Galaxy Nexus
OS: Android 4.0.4

Steps to reproduce:
1. Open Fennec
2. Browse to any webpage
3. Tap on Menu > Find in Page
4. Type any search criteria
5. Tap on up/down arrows

Expected result:
VKB is dismissed at step 5.

Actual result:
VKB is not dismissed at step 5. Sometimes it will be dismissed after several taps.

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Are we sure we want the keyboard to close when tapping the arrows? We have other bugs open for closing the keyboard too much when "finding". Why should we close it?

Comment 2

[Cristian Nicolae (:xti)]

(In reply to Mark Finkle (:mfinkle) from comment #1)
> Are we sure we want the keyboard to close when tapping the arrows? We have
> other bugs open for closing the keyboard too much when "finding". Why should
> we close it?

When searching for something, I guess it's better to view the webpage as much as possible. It happens sometimes to tap by mistake above the Find in Page UI and the VKB is dismissed and then quick tapping on the same place where were the find buttons. This will cause accidental taps on links from that page. However, if the VKB is dismissed on the first arrow button tap, then user will have a better perspective and we will avoid scenarios like mentioned above. Also if the search criteria needs to be changed, a tap in the field will trigger back the vkb.

Comment 3

[Aaron Train [:aaronmt]]

Chrome/Android both close the keyboard

Comment 4

[Brad Lassey [:blassey] (use needinfo?)]

not sure if we'd actually want to change this. Uiwanted to make a decision, please renom if you want to change anything.

Comment 5

[Alex Keybl [:akeybl]]

Leaving this in the queue, and assigning to Madhava to make the final call on whether this would block the feature. If not, we'll minus for release tracking.

Comment 6

[Madhava Enros [:madhava]]

Hi everyone -

I think the interactions should look like this:

- open find in page, the bar appears, field is focused so the keyboard comes up

- as you type, we move to the first match, progressively as you type more and more.
   - keyboard stays up because we don't know if you're done typing; you may just type more and more until you find the match; the keyboard should not go away just because we've found the first match or are out of matches

- if you pan or tap in the content area, the keyboard is dismissed but the find-in-page bar remains at the bottom of the screen

- if you tap a forward or next button, you're indicating that you've entered as much text as you're going to for the moment, so we should clear up more room to let you better see the content; we dismiss the keyboard but leave the findbar present on the screen

- you can tap the field in the findbar to re-focus it and continue typing, so the keyboard should come up at that point

- if you close the findbar (with the dismiss x), the keyboard should go away too

Comment 7

[Alex Keybl [:akeybl]]

We're shipping the feature as is in FF15, but just fyi the following are not to Madhava's spec:

> - if you pan or tap in the content area, the keyboard is dismissed but the
> find-in-page bar remains at the bottom of the screen

> - if you tap a forward or next button, you're indicating that you've entered
> as much text as you're going to for the moment, so we should clear up more
> room to let you better see the content; we dismiss the keyboard but leave
> the findbar present on the screen

Comment 8

[Mark Finkle (:mfinkle) (use needinfo?)]

tl;dr

if you tap a forward or next button, you're indicating that you've entered as much text as you're going to for the moment, so we should clear up more room to let you better see the content; we dismiss the keyboard but leave the findbar present on the screen

Comment 9

[:Margaret Leibovic]

Attachment: patch

This turned out to be pretty simple.

Comment 10

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6351566e6083

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6351566e6083