Last Comment Bug 772506 - Make sure jsterm eval results are correctly formatted as strings
: Make sure jsterm eval results are correctly formatted as strings
Status: RESOLVED FIXED
:
Product: Firefox
Classification: Client Software
Component: Developer Tools: Console (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Firefox 16
Assigned To: Mihai Sucan [:msucan]
:
: Brian Grinstead [:bgrins]
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-10 09:21 PDT by Mihai Sucan [:msucan]
Modified: 2012-07-10 23:45 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
proposed fix (5.31 KB, patch)
2012-07-10 09:33 PDT, Mihai Sucan [:msucan]
rcampbell: review+
Details | Diff | Splinter Review

Description Mihai Sucan [:msucan] 2012-07-10 09:21:45 PDT
We don't always correctly format JS eval results as strings. We need a fix!
Comment 1 Mihai Sucan [:msucan] 2012-07-10 09:33:42 PDT
Created attachment 640637 [details] [diff] [review]
proposed fix

This is the patch. Please let me know if further changes are needed. Thanks!
Comment 2 Rob Campbell [:rc] (:robcee) 2012-07-10 09:37:30 PDT
Comment on attachment 640637 [details] [diff] [review]
proposed fix

yup.
Comment 3 Mihai Sucan [:msucan] 2012-07-10 10:40:37 PDT
Comment on attachment 640637 [details] [diff] [review]
proposed fix

Thanks for the review!

Landed:
https://hg.mozilla.org/integration/fx-team/rev/6c31b06b0c8f
Comment 4 Tim Taubert [:ttaubert] 2012-07-10 23:45:57 PDT
https://hg.mozilla.org/mozilla-central/rev/6c31b06b0c8f

Note You need to log in before you can comment on or make changes to this bug.