Closed
Bug 772510
Opened 13 years ago
Closed 13 years ago
Build warning in DoorHanger.java:171
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 16
People
(Reporter: cwiiis, Assigned: cwiiis)
Details
Attachments
(1 file)
|
1.23 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
Building a recent check-out of m-c, I get this build warning:
/home/cwiiis/Projects/mozilla-central/mobile/android/base/DoorHanger.java:171: warning: [static] static variable should be qualified by type name, GeckoApp, instead of by an expression
if (mPersistWhileVisible && GeckoApp.mAppContext.mDoorHangerPopup.isShowing()) {
Patch incoming.
|
Assignee | |
Comment 1•13 years ago
|
||
Fix warning by accessing static class variable via class name instead of variable name.
Attachment #640635 -
Flags: review?(mark.finkle)
|
||
Updated•13 years ago
|
Attachment #640635 -
Flags: review?(mark.finkle) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Pushed to inbound: http://hg.mozilla.org/integration/mozilla-inbound/rev/e6b770b14572
|
||
Comment 3•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 16
|
||
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•