Closed
Bug 772523
Opened 13 years ago
Closed 13 years ago
nsMemoryCacheDevice::mEvictionThreshold is unused
Categories
(Core :: Networking: Cache, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
1.51 KB,
patch
|
michal
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Attachment #640644 -
Flags: review?(jduell.mcbugs)
|
Assignee | |
Updated•13 years ago
|
Assignee: nobody → ehsan
|
||
Comment 1•13 years ago
|
||
Comment on attachment 640644 [details] [diff] [review]
Patch (v1)
Review of attachment 640644 [details] [diff] [review]:
-----------------------------------------------------------------
Looks fine to me, but want to run by michal in case we should be using it instead of removing.
Attachment #640644 -
Flags: review?(jduell.mcbugs) → review?(michal.novotny)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 640644 [details] [diff] [review]
Patch (v1)
(In reply to Jason Duell (:jduell) from comment #1)
> Looks fine to me, but want to run by michal in case we should be using it
> instead of removing.
Usage of mEvictionThreshold was removed in bug #188458 a long time ago. I don't think we want or need to change the current LRU-SP's cost calculation...
Attachment #640644 -
Flags: review?(michal.novotny) → review+
|
|
Assignee | |
Comment 3•13 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•