nsMemoryCacheDevice::mEvictionThreshold is unused

RESOLVED FIXED in mozilla16

Status

()

Core
Networking: Cache
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

Trunk
mozilla16
x86_64
Linux
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [build_warning])

Attachments

(1 attachment)

Created attachment 640644 [details] [diff] [review]
Patch (v1)
Attachment #640644 - Flags: review?(jduell.mcbugs)
Assignee: nobody → ehsan
Comment on attachment 640644 [details] [diff] [review]
Patch (v1)

Review of attachment 640644 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, but want to run by michal in case we should be using it instead of removing.
Attachment #640644 - Flags: review?(jduell.mcbugs) → review?(michal.novotny)
Comment on attachment 640644 [details] [diff] [review]
Patch (v1)

(In reply to Jason Duell (:jduell) from comment #1)
> Looks fine to me, but want to run by michal in case we should be using it
> instead of removing.

Usage of mEvictionThreshold was removed in bug #188458 a long time ago. I don't think we want or need to change the current LRU-SP's cost calculation...
Attachment #640644 - Flags: review?(michal.novotny) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/7cf25b6002ae
Target Milestone: --- → mozilla16

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7cf25b6002ae
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.