Last Comment Bug 772523 - nsMemoryCacheDevice::mEvictionThreshold is unused
: nsMemoryCacheDevice::mEvictionThreshold is unused
Status: RESOLVED FIXED
[build_warning]
:
Product: Core
Classification: Components
Component: Networking: Cache (show other bugs)
: Trunk
: x86_64 Linux
: -- normal (vote)
: mozilla16
Assigned To: :Ehsan Akhgari
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-10 09:52 PDT by :Ehsan Akhgari
Modified: 2012-07-12 09:40 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (v1) (1.51 KB, patch)
2012-07-10 09:52 PDT, :Ehsan Akhgari
michal.novotny: review+
Details | Diff | Splinter Review

Description :Ehsan Akhgari 2012-07-10 09:52:51 PDT
Created attachment 640644 [details] [diff] [review]
Patch (v1)
Comment 1 Jason Duell [:jduell] (needinfo me) 2012-07-10 23:36:31 PDT
Comment on attachment 640644 [details] [diff] [review]
Patch (v1)

Review of attachment 640644 [details] [diff] [review]:
-----------------------------------------------------------------

Looks fine to me, but want to run by michal in case we should be using it instead of removing.
Comment 2 Michal Novotny (:michal) 2012-07-11 02:44:10 PDT
Comment on attachment 640644 [details] [diff] [review]
Patch (v1)

(In reply to Jason Duell (:jduell) from comment #1)
> Looks fine to me, but want to run by michal in case we should be using it
> instead of removing.

Usage of mEvictionThreshold was removed in bug #188458 a long time ago. I don't think we want or need to change the current LRU-SP's cost calculation...
Comment 4 Ed Morley [:emorley] 2012-07-12 09:40:23 PDT
https://hg.mozilla.org/mozilla-central/rev/7cf25b6002ae

Note You need to log in before you can comment on or make changes to this bug.