Closed Bug 772570 Opened 13 years ago Closed 13 years ago

Build failure: Cannot open include file: 'vpx/vpx_encoder.h' @ reference_picture_selection.cc

Categories

(Core :: WebRTC: Audio/Video, defect)

Product:
Core
Component:
WebRTC: Audio/Video
Platform:
x86_64
Windows 7
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla17

People

(Reporter: mayhemer, Assigned: jesup)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 1 obsolete file)

untangle MOZ_WEBM from MOZ_VP8 so we can disable webm with webrtc enabled (updated)
1.80 KB, patch
derf
: review+
ted
: review+
Details | Diff | Splinter Review
Windows 7, VC10, pymake. .mozconfig: # Options for client.mk. mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/_obj-browser-debug mk_add_options MOZ_MAKE_FLAGS=-j9 # Options for 'configure' (same as command-line options). #ac_add_options --enable-jemalloc export MOZ_DEBUG_SYMBOLS=1 ac_add_options --enable-application=browser ac_add_options --enable-debug ac_add_options --disable-optimize ac_add_options --enable-shared ac_add_options --disable-static ac_add_options --enable-tests ac_add_options --enable-logging ac_add_options --enable-visual-event-tracer ac_add_options --disable-installer ac_add_options --enable-chrome-format=flat ac_add_options --disable-crashreporter ac_add_options --disable-webm # <<<<< notice this option please ac_add_options --disable-accessibility ac_add_options --disable-angle system-libvpx has no effect on win. adding --disable-webrtc works the problem around, but that is just a short term option since I will soon need to build webrt on my machine. Complete command: c:\Mozilla\src\mozilla-central\config\rules.mk:1021:0$ c:/Mozilla/src/mozilla-central/_obj-browser-debug/_virtualenv/Scripts/python.exe -O ../../../../../../. ./build/cl.py cl -Fovideo_coding/codecs/vp8/main/source/reference_picture_selection.obj -c -D_WIN32_WINNT=0x0601 -DWINVER=0x0601 -DWIN32 -D_WINDOWS -DNOMINM AX -DPSAPI_VERSION=1 -D_CRT_RAND_S -DCERT_CHAIN_PARA_HAS_EXTRA_FIELDS -DWIN32_LEAN_AND_MEAN -D_ATL_NO_OPENGL -D_HAS_TR1=0 -D_HAS_EXCEPTIONS=0 -D_SECURE_ATL -D CHROMIUM_BUILD -DTOOLKIT_VIEWS=1 -DENABLE_REMOTING=1 -DENABLE_P2P_APIS=1 -DENABLE_CONFIGURATION_POLICY -DENABLE_INPUT_SPEECH -DENABLE_NOTIFICATIONS -DENABLE_G PU=1 -DENABLE_EGLIMAGE=1 -DUSE_SKIA=1 -D__STD_C -D_CRT_SECURE_NO_DEPRECATE -D_SCL_SECURE_NO_DEPRECATE -DENABLE_REGISTER_PROTOCOL_HANDLER=1 -DENABLE_WEB_INTENT S=1 -DENABLE_PLUGIN_INSTALLATION=1 -DWEBRTC_WIN -DWEBRTC_EXPORT -DWEBRTC_LIBVPX_VERSION=971 -DWEBRTC_LIBVPX_TEMPORAL_LAYERS=0 -D__STDC_FORMAT_MACROS -DDYNAMIC _ANNOTATIONS_ENABLED=1 -DWTF_USE_DYNAMIC_ANNOTATIONS=1 -DUNICODE -D_UNICODE -I. -I../../../../../../../media/webrtc/trunk/src/modules/.. -I../../../../../../. ./media/webrtc/trunk/src/modules/../.. -I../../../../../../../media/webrtc/trunk/src/modules/../../third_party/wtl/include -I../../../../../../../media/webrtc /trunk/src/modules/video_coding/codecs/vp8/main/interface -I../../../../../../../media/webrtc/trunk/src/modules/../../src/common_video/interface -I../../../.. /../../../media/webrtc/trunk/src/modules/../../src/modules/video_coding/codecs/interface -I../../../../../../../media/webrtc/trunk/src/modules/../../src/modul es/interface -I../../../../../../dist/include -I../../../../../../../media/webrtc/trunk/src/modules/../system_wrappers/interface -I"/include" -TP -nologo - W3 -Gy -Fdgenerated.pdb -wd4800 -we4553 -GR- -DDEBUG -D_DEBUG -DTRACING -Zi -Oy- -MDd -FI ../../../../../../dist/include/mozilla-config.h -DMOZILL A_CLIENT c:/Mozilla/src/mozilla-central/_obj-browser-debug/media/webrtc/trunk/src/modules/modules_webrtc_vp8/../../../../../../../media/webrtc/trunk/src/modul es/video_coding/codecs/vp8/main/source/reference_picture_selection.cc reference_picture_selection.cc c:\Mozilla\src\mozilla-central\_obj-browser-debug\media\webrtc\trunk\src\modules\modules_webrtc_vp8\../../../../../../dist/include/mozilla-config.h(98) : warn ing C4005: 'WINVER' : macro redefinition command-line arguments : see previous definition of 'WINVER' c:\Mozilla\src\mozilla-central\_obj-browser-debug\media\webrtc\trunk\src\modules\modules_webrtc_vp8\../../../../../../dist/include/mozilla-config.h(105) : war ning C4005: '_WIN32_WINNT' : macro redefinition command-line arguments : see previous definition of '_WIN32_WINNT' c:/Mozilla/src/mozilla-central/_obj-browser-debug/media/webrtc/trunk/src/modules/modules_webrtc_vp8/../../../../../../../media/webrtc/trunk/src/modules/video_ coding/codecs/vp8/main/source/reference_picture_selection.cc(14) : fatal error C1083: Cannot open include file: 'vpx/vpx_encoder.h': No such file or directory
Probably a configure.in issue between the two options
Assignee: nobody → rjesup
(In reply to Randell Jesup [:jesup] from comment #1) > Probably a configure.in issue between the two options I don't think it's configure.in that's the problem, but toolkit/toolkit-makefiles.sh and toolkit/toolkit-tiers.mk. Both of those add media/libvpx things to the build behind a MOZ_WEBM flag instead of a MOZ_VP8 flag. layout/media/symbols.def.in has a similar problem.
Ok, thanks. Just did a full build with the options given (on Linux!) and it was fine....
I believe this this just related to Windows. How do we build on the production build machines? Looks like I should install VP8 support for win and make it available to the moz build config.
(In reply to Honza Bambas (:mayhemer) from comment #4) > I believe this this just related to Windows. How do we build on the > production build machines? Looks like I should install VP8 support for win > and make it available to the moz build config. We should _not_ be pulling in system libvpx by default. We should be using the in-tree copy.
Attachment #640761 - Attachment is obsolete: true
Honza: please give either of these a try. (The update won't actually change your result).
I'll try probably tomorrow. Thanks for quick reaction, though.
Comment on attachment 640771 [details] [diff] [review] untangle MOZ_WEBM from MOZ_VP8 so we can disable webm with webrtc enabled (updated) So, I've removed --disable-webrtc from my mozconfig and with this patch I can build. Thanks for a quick fix!
Comment on attachment 640771 [details] [diff] [review] untangle MOZ_WEBM from MOZ_VP8 so we can disable webm with webrtc enabled (updated) Checking with ted if this needs build peer review too
Attachment #640771 - Flags: review?(tterribe)
Attachment #640771 - Flags: review?(tterribe) → review+
Comment on attachment 640771 [details] [diff] [review] untangle MOZ_WEBM from MOZ_VP8 so we can disable webm with webrtc enabled (updated) Since ted said on IRC he'd need to look to know if it needs build system peer review, asking for review.
Attachment #640771 - Flags: review?(ted.mielczarek)
Ted, any chance to move forward here? I have to apply this patch on all platforms I build on. Thanks.
Attachment #640771 - Flags: review?(ted.mielczarek) → review+
https://hg.mozilla.org/mozilla-central/rev/d2561fcf4882
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
Whiteboard: [qa-]
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: