772598 - String disparity in 'Site preferences' vs: 'Clear site Settings'

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Aaron Train [:aaronmt]]

Preferences vs Settings.

site_settings_title
pref_private_data_siteSettings

Comment 1

[:Margaret Leibovic]

In general we use "settings" on Android, not "preferences". Also, in both cases, it's really more about permissions than preferences (although not for passwords, but that's maybe a site-vs-browser issue that users don't need to worry about).

Also, while we're dealing with these strings, "Clear Site Settings" should really have an ellipsis. I'm not sure if a bug has been filed about that in the past.

Comment 2

[Brian Nicholson (:bnicholson)]

(In reply to Margaret Leibovic [:margaret] from comment #1)
> Also, while we're dealing with these strings, "Clear Site Settings" should
> really have an ellipsis. I'm not sure if a bug has been filed about that in
> the past.

There was a similar discussion in https://bugzilla.mozilla.org/show_bug.cgi?id=754335#c41.

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Aaron - What parts of the UI are we talking about here? (Screenshots?)

Comment 4

[Aaron Train [:aaronmt]]

Settings -> Clear private data -> "Site preferences"

vs.

Menu button -> "Clear Site Settings"

Do these even clear the same things ?

Comment 5

[:Margaret Leibovic]

I agree with Aaron. I think we should s/Site preferences/Site settings.

I'm not sure how we even ended up with preferences in the string. The entity is named pref_private_data_siteSettings.

Comment 6

[Ian Barlow (:ibarlow)]

+1 for "Site settings"

Comment 7

[:Margaret Leibovic]

Attachment: patch

Comment 8

[:Margaret Leibovic]

Attachment: patch

Oops, other stuff made it into that first patch.

Comment 9

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f54de2bc565b

Comment 10

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/f54de2bc565b