772616 - Include Marionette and Marionette tests in tests.zip

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Jonathan Griffin (:jgriffin)]

In order to run Marionette tests in TBPL, we'll need to store Marionette and Marionette tests in tests.zip

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: patch v0.1

Submitted to try so I can verify that tests.zip contains the expected files.

Comment 2

[Mozilla RelEng Bot]

Try run for 3a204b8e9906 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=3a204b8e9906
Results (out of 17 total builds):
    success: 8
    failure: 9
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-3a204b8e9906

Comment 3

[Jonathan Griffin (:jgriffin)]

The build failures are caused by use of os.path.relpath, which was introduced in Python 2.6.

Comment 4

[Jonathan Griffin (:jgriffin)]

Attachment: patch v0.2

Adds an implementation of relpath for versions of Python < 2.6.

Comment 5

[Mozilla RelEng Bot]

Try run for ea0f9602766f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=ea0f9602766f
Results (out of 17 total builds):
    success: 17
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-ea0f9602766f

Comment 6

[Jonathan Griffin (:jgriffin)]

Comment on attachment 641292 [details] [diff] [review]
patch v0.2

I've run this through try and it produces the desired results.

Comment 7

[Jonathan Griffin (:jgriffin)]

Attachment: patch v0.3

Updated patch to retain in-tree relative paths, and remove create-package-manifest.py.

Comment 8

[(not currently active) Ted Mielczarek]

Comment on attachment 645009 [details] [diff] [review]
patch v0.3

Review of attachment 645009 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/tests/print-manifest-dirs.py
@@ +6,5 @@
> +
> +lineRE = re.compile(r'\[\s*include:\s*[\.\.\/]+(.*?)manifest.ini')
> +
> +def print_test_dirs(topsrcdir, manifest):
> +    """Simple routine which prints the abs paths of directories specified

nit: putting the first line of the docstring on the next line would make the indentation look less weird.

@@ +19,5 @@
> +
> +    # output the manifest dirs
> +    f = open(manifest, 'r')
> +    for line in f:
> +        m = lineRE.search(line)

Does the manifestdestiny package give you enough info to do this? Seems like that'd be a nicer than regexing if so.

Comment 9

[Jonathan Griffin (:jgriffin)]

Attachment: patch v0.4

Updated to use manifestparser; pushed to try:  https://tbpl.mozilla.org/?tree=Try&rev=aba299a7ff9d

Carrying r+ forward.

Comment 10

[Mozilla RelEng Bot]

Try run for aba299a7ff9d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=aba299a7ff9d
Results (out of 17 total builds):
    success: 17
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/[e-mail]-aba299a7ff9d

Comment 11

[Jonathan Griffin (:jgriffin)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/aabdcbada68d

Comment 12

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/aabdcbada68d