Include Marionette and Marionette tests in tests.zip

RESOLVED FIXED in mozilla17

Status

defect
RESOLVED FIXED
7 years ago
7 years ago

People

(Reporter: jgriffin, Assigned: jgriffin)

Tracking

unspecified
mozilla17
x86
macOS
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 3 obsolete attachments)

In order to run Marionette tests in TBPL, we'll need to store Marionette and Marionette tests in tests.zip
Blocks: 770769
Posted patch patch v0.1 (obsolete) — Splinter Review
Submitted to try so I can verify that tests.zip contains the expected files.
Try run for 3a204b8e9906 is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=3a204b8e9906
Results (out of 17 total builds):
    success: 8
    failure: 9
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jgriffin@mozilla.com-3a204b8e9906
The build failures are caused by use of os.path.relpath, which was introduced in Python 2.6.
Posted patch patch v0.2 (obsolete) — Splinter Review
Adds an implementation of relpath for versions of Python < 2.6.
Attachment #641134 - Attachment is obsolete: true
Try run for ea0f9602766f is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=ea0f9602766f
Results (out of 17 total builds):
    success: 17
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jgriffin@mozilla.com-ea0f9602766f
Comment on attachment 641292 [details] [diff] [review]
patch v0.2

I've run this through try and it produces the desired results.
Attachment #641292 - Flags: review?(ted.mielczarek)
Posted patch patch v0.3 (obsolete) — Splinter Review
Updated patch to retain in-tree relative paths, and remove create-package-manifest.py.
Attachment #641292 - Attachment is obsolete: true
Attachment #641292 - Flags: review?(ted.mielczarek)
Attachment #645009 - Flags: review?(ted.mielczarek)
Comment on attachment 645009 [details] [diff] [review]
patch v0.3

Review of attachment 645009 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/marionette/client/marionette/tests/print-manifest-dirs.py
@@ +6,5 @@
> +
> +lineRE = re.compile(r'\[\s*include:\s*[\.\.\/]+(.*?)manifest.ini')
> +
> +def print_test_dirs(topsrcdir, manifest):
> +    """Simple routine which prints the abs paths of directories specified

nit: putting the first line of the docstring on the next line would make the indentation look less weird.

@@ +19,5 @@
> +
> +    # output the manifest dirs
> +    f = open(manifest, 'r')
> +    for line in f:
> +        m = lineRE.search(line)

Does the manifestdestiny package give you enough info to do this? Seems like that'd be a nicer than regexing if so.
Attachment #645009 - Flags: review?(ted.mielczarek) → review+
Posted patch patch v0.4Splinter Review
Updated to use manifestparser; pushed to try:  https://tbpl.mozilla.org/?tree=Try&rev=aba299a7ff9d

Carrying r+ forward.
Attachment #645009 - Attachment is obsolete: true
Attachment #645370 - Flags: review+
Try run for aba299a7ff9d is complete.
Detailed breakdown of the results available here:
    https://tbpl.mozilla.org/?tree=Try&rev=aba299a7ff9d
Results (out of 17 total builds):
    success: 17
Builds (or logs if builds failed) available at:
http://ftp.mozilla.org/pub/mozilla.org/firefox/try-builds/jgriffin@mozilla.com-aba299a7ff9d
https://hg.mozilla.org/mozilla-central/rev/aabdcbada68d
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.