JS Profile feature crash if used on startup

RESOLVED FIXED in mozilla16

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

unspecified
mozilla16
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
If we try to call 'js::SetRuntimeProfilingStack' before we have a JS runtime and before the JS engine is started and we crash. We start profiling on start up in mobile since we use an environment variable to start.

Simple fix is to delay profiling until we get a runtime.
(Assignee)

Comment 1

5 years ago
Created attachment 640764 [details] [diff] [review]
Delay JS profiling until we have a runtime

Also use JS profiling by default on mobile.
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #640764 - Flags: review?(ehsan)
Attachment #640764 - Flags: review?(acrichton)

Updated

5 years ago
Attachment #640764 - Flags: review?(acrichton) → review+
Attachment #640764 - Flags: review?(ehsan) → review+
(Assignee)

Comment 2

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/506be1161172
Target Milestone: --- → mozilla16

Comment 3

5 years ago
https://hg.mozilla.org/mozilla-central/rev/506be1161172
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.