772651 - change name for temp directory from hard-coding

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Arkady Blyakher [:rkd]]

Attachment: change name for temp directory for image sharing

addresses https://bugzilla.mozilla.org/show_bug.cgi?id=769438#c9

Comment 2

[Brad Lassey [:blassey] (use needinfo?)]

Comment on attachment 640812 [details] [diff] [review]
change name for temp directory for image sharing

Review of attachment 640812 [details] [diff] [review]:
-----------------------------------------------------------------

::: mobile/android/base/GeckoApp.java
@@ +2308,5 @@
>  
>      // Get/Create a temporary direcory
>      public static File getTempDirectory() {
>          File sdcard = Environment.getExternalStorageDirectory();
> +        File dir = new File(sdcard.getAbsolutePath(), GeckoApp.mAppContext.getPackageName());

File dir = mAppContext.getExternalFilesDir("temp");

Comment 3

[Arkady Blyakher [:rkd]]

Attachment: change name for temp directory for image sharing

Comment 4

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 640827 [details] [diff] [review]
change name for temp directory for image sharing

I assume this works for "sharing" files. Why not just remove getTempDirectory() and use mAppContext.getExternalFilesDir("temp") directly?

r+ if blassey likes this too

Comment 5

[Arkady Blyakher [:rkd]]

(In reply to Mark Finkle (:mfinkle) from comment #4)
> Comment on attachment 640827 [details] [diff] [review]
> change name for temp directory for image sharing
> 
> I assume this works for "sharing" files. Why not just remove
> getTempDirectory() and use mAppContext.getExternalFilesDir("temp") directly?
> 
> r+ if blassey likes this too

This makes a "temp" folder in the external files dir, so that we can reuse that directory for storing other things and not worry about deleting files outside of that /temp.

Comment 6

[David Zbarsky (:dzbarsky)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/cd48fae38214

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/cd48fae38214