Closed Bug 772687 Opened 11 years ago Closed 11 years ago

Add ability to specify deviceRoot in DeviceManagerADB __init__

Categories

(Testing :: Mozbase, defect)

Product:
Testing
Component:
Mozbase
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla16

People

(Reporter: jgriffin, Assigned: jgriffin)

References

Details

Attachments

(1 file, 2 obsolete files)

patch v0.3
6.91 KB, patch
jmaher
: review+
Details | Diff | Splinter Review
Attached patch patch v0.1 (obsolete) — — Splinter Review 
On B2G, we cannot use the SD card as the device root, as B2G cannot read the profile from there.  However, we cannot use DeviceManagerADB to create "/data/local/tests" in order to force that dir as the deviceRoot, since the deviceRoot is set (via setupDeviceRoot) in __init__.

This patch fixes that, so you can optionally pass a deviceRoot to __init__, which will be created for you if it doesn't exist.  If you omit deviceRoot, the previous behavior is preserved.

This also patches the related B2G mochitest code to use this new feature.
Attachment #640851 - Flags: review?(jmaher)
Attached patch patch v0.2 (obsolete) — — Splinter Review 
Fix a silly mistake: testPath -> testDir
Attachment #640851 - Attachment is obsolete: true
Attachment #640851 - Flags: review?(jmaher)
Attachment #640878 - Flags: review?(jmaher)
Comment on attachment 640878 [details] [diff] [review]
patch v0.2

Review of attachment 640878 [details] [diff] [review]:
-----------------------------------------------------------------

if we could try to make devicemanagerSUT behave the same that would be nice.  These files are splitting apart and that is concerning.  File a bug if you don't feel comfortable doing that.
Attachment #640878 - Flags: review?(jmaher) → review+
Attached patch patch v0.3 — — Splinter Review 
This version adds corresponding functionality to devicemanagerSUT.py.
Attachment #640878 - Attachment is obsolete: true
Attachment #641098 - Flags: review?(jmaher)
Comment on attachment 641098 [details] [diff] [review]
patch v0.3

Review of attachment 641098 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!
Attachment #641098 - Flags: review?(jmaher) → review+
http://hg.mozilla.org/integration/mozilla-inbound/rev/90f88b503848
Assignee: nobody → jgriffin
Target Milestone: --- → mozilla16
https://hg.mozilla.org/mozilla-central/rev/90f88b503848
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.