ban xml in function defaults

RESOLVED FIXED in mozilla16

Status

()

Core
JavaScript Engine
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Benjamin, Assigned: Benjamin)

Tracking

unspecified
mozilla16
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Even after bug 769072, you can put XML in function defaults like:
function f(a=<x/>) { "use strict"; }

This is because XML doesn't report strict errors. Let's just completely ban XML in defaults.
(Assignee)

Comment 1

5 years ago
Created attachment 640865 [details] [diff] [review]
ban XML in defaults

Not exactly straight forward, but I think we're escaping E4X with only a few scratches.
Assignee: general → bpeterson
Attachment #640865 - Flags: review?(n.nethercote)
Comment on attachment 640865 [details] [diff] [review]
ban XML in defaults

Review of attachment 640865 [details] [diff] [review]:
-----------------------------------------------------------------

The best thing about this patch is that it will be removed in the not-too-distant future, when e4x is removed :)
Attachment #640865 - Flags: review?(n.nethercote) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/ee74ca523ff2
Flags: in-testsuite+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/ee74ca523ff2
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in before you can comment on or make changes to this bug.