Closed
Bug 772691
Opened 13 years ago
Closed 13 years ago
ban xml in function defaults
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: Benjamin, Assigned: Benjamin)
Details
Attachments
(1 file)
|
5.40 KB,
patch
|
n.nethercote
:
review+
|
Details | Diff | Splinter Review |
Even after bug 769072, you can put XML in function defaults like:
function f(a=<x/>) { "use strict"; }
This is because XML doesn't report strict errors. Let's just completely ban XML in defaults.
|
Assignee | |
Comment 1•13 years ago
|
||
Not exactly straight forward, but I think we're escaping E4X with only a few scratches.
Assignee: general → bpeterson
Attachment #640865 -
Flags: review?(n.nethercote)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 640865 [details] [diff] [review]
ban XML in defaults
Review of attachment 640865 [details] [diff] [review]:
-----------------------------------------------------------------
The best thing about this patch is that it will be removed in the not-too-distant future, when e4x is removed :)
Attachment #640865 -
Flags: review?(n.nethercote) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 3•13 years ago
|
||
Flags: in-testsuite+
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
You need to log in
before you can comment on or make changes to this bug.
Description
•