Closed
Bug 772738
Opened 13 years ago
Closed 13 years ago
Avoid "unused variable 'tmp'" warnings for empty CC traverse method implementations
Categories
(Core :: XPCOM, defect)
Tracking
()
RESOLVED
FIXED
mozilla16
People
(Reporter: ehsan.akhgari, Assigned: ehsan.akhgari)
Details
(Whiteboard: [build_warning])
Attachments
(1 file)
|
817 bytes,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
moz/mozilla-central/dom/indexedDB/IDBWrapperCache.cpp:14:1: warning: unused variable 'tmp' [-Wunused-variable]
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED(IDBWrapperCache,
^
../../dist/include/nsCycleCollectionParticipant.h:517:3: note: expanded from macro 'NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INHERITED'
NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INTERNAL(_class) \
^
../../dist/include/nsCycleCollectionParticipant.h:504:13: note: expanded from macro 'NS_IMPL_CYCLE_COLLECTION_TRAVERSE_BEGIN_INTERNAL'
_class *tmp = static_cast<_class*>(Downcast(s));
^
1 warning generated.
The UNLINK_END macro has this protection in place. We should add it for TRAVERSE too.
|
Assignee | |
Updated•13 years ago
|
Whiteboard: [build_warning]
|
|
Assignee | |
Comment 1•13 years ago
|
||
|
||
Updated•13 years ago
|
Attachment #640909 -
Flags: review?(bugs) → review+
|
|
Assignee | |
Comment 2•13 years ago
|
||
Target Milestone: --- → mozilla16
|
||
Comment 3•13 years ago
|
||
Weird, I thought I'd gone through and fixed all of these. Thanks for fixing it!
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•