As a security precaution, we have turned on the setting "Require API key authentication for API requests" for everyone. If this has broken something, please contact
Last Comment Bug 772758 - Clean up some build warnings in html5 parser
: Clean up some build warnings in html5 parser
Product: Core
Classification: Components
Component: HTML: Parser (show other bugs)
: unspecified
: All All
: -- normal (vote)
: mozilla16
Assigned To: David Zbarsky (:dzbarsky)
: Andrew Overholt [:overholt]
Depends on:
  Show dependency treegraph
Reported: 2012-07-11 00:33 PDT by David Zbarsky (:dzbarsky)
Modified: 2012-09-21 05:21 PDT (History)
2 users (show)
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

PAtch (3.95 KB, patch)
2012-07-11 00:34 PDT, David Zbarsky (:dzbarsky)
hsivonen: review+
Details | Diff | Splinter Review
Corresponding diff (942 bytes, patch)
2012-07-13 05:58 PDT, Henri Sivonen (:hsivonen)
no flags Details | Diff | Splinter Review

Description User image David Zbarsky (:dzbarsky) 2012-07-11 00:33:48 PDT

Comment 1 User image David Zbarsky (:dzbarsky) 2012-07-11 00:34:40 PDT
Created attachment 640962 [details] [diff] [review]
Comment 2 User image Henri Sivonen (:hsivonen) 2012-07-13 05:56:52 PDT
Comment on attachment 640962 [details] [diff] [review]

r+, provided that you fold in the patch I'll attach shortly.
Comment 3 User image Henri Sivonen (:hsivonen) 2012-07-13 05:58:00 PDT
Created attachment 641841 [details] [diff] [review]
Corresponding diff

Here's the patch to be folded in.
Comment 4 User image David Zbarsky (:dzbarsky) 2012-07-13 12:01:53 PDT
Pushed with patch:
Comment 5 User image Ryan VanderMeulen [:RyanVM] 2012-07-13 20:22:23 PDT
Comment 6 User image Henri Sivonen (:hsivonen) 2012-09-21 05:21:58 PDT

Note You need to log in before you can comment on or make changes to this bug.