772801 - B2G Wifi: Fix wifi scanning on ICS

Status: RESOLVED FIXED

(Core :: Hardware Abstraction Layer (HAL), defect)

Description

[Vincent Chang[:vchang][changyihsin]]

Attachment: WIP

Wifi scanning on ICS is broken for Otoro devices.

Comment 1

[Vincent Chang[:vchang][changyihsin]]

Attachment: WIP

Comment 2

[Vincent Chang[:vchang][changyihsin]]

Attachment: wpa_supplicant.conf

replaced /data/misc/wifi/wpa_supplicant.conf

Comment 3

[John Hammink]

We're currently blocked on testing due to this.  Here's the related gaia issue:
https://github.com/mozilla-b2g/gaia/issues/2361 - [settings] Wifi scans but does not present list of SSIDs

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 641014 [details] [diff] [review]
WIP

This is the right approach. I have a cleaned-up patch as well.

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Cleaner patch

Comment 6

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 641633 [details] [diff] [review]
Cleaner patch

https://hg.mozilla.org/mozilla-central/rev/32c911bc2579

Comment 7

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Followup

mwu, I hope you don't mind reviewing this... basically this patch lets us not do the active/passive scanning stuff if the driver doesn't support it.

Comment 8

[Michael Wu [:mwu]]

Comment on attachment 641689 [details] [diff] [review]
Followup

Not true - passive scans are fully supported with a nl80211 driver. wpa_supplicant just isn't exposing an interface to do it, and why should it? An active scan is what you want 98% of the time. WifiWorker.js probably shouldn't care about scan modes at all.

Comment 9

[Tony Chung [:tchung]]

flagging blocking-basecamp

Comment 10

[Tony Chung [:tchung]]

This is still reproducible on a daily otoro build of 7-17-2012.   

REpro:
1) load settings > wifi
2) uncheck the wifi checkbox  (assuming you had networks found before)
3) recheck the wifi checkbox
4) Verify no networks are ever scanned or found again.

Comment 11

[Michael Wu [:mwu]]

(In reply to Tony Chung [:tchung] from comment #10)
> This is still reproducible on a daily otoro build of 7-17-2012.   
> 
> REpro:
> 1) load settings > wifi
> 2) uncheck the wifi checkbox  (assuming you had networks found before)
> 3) recheck the wifi checkbox
> 4) Verify no networks are ever scanned or found again.

That is a different issue.

Comment 12

[Dietrich Ayala (:dietrich)]

Tony, don't be a flag-clearer! ;)

Comment 13

[Tony Chung [:tchung]]

(In reply to Michael Wu [:mwu] from comment #11)
> (In reply to Tony Chung [:tchung] from comment #10)
> > This is still reproducible on a daily otoro build of 7-17-2012.   
> > 
> > REpro:
> > 1) load settings > wifi
> > 2) uncheck the wifi checkbox  (assuming you had networks found before)
> > 3) recheck the wifi checkbox
> > 4) Verify no networks are ever scanned or found again.
> 
> That is a different issue.

okay, i filed https://bugzilla.mozilla.org/show_bug.cgi?id=774876 to track this.

Comment 14

[Gene Lian (I already quit Mozilla)]

Does this one look like a duplicate issue by Bug 782020 I just fired?

Comment 15

[Michael Wu [:mwu]]

Resolving this bug since the main issue is already fixed. I don't think we really need the follow up so I've cleared review, but we can do that in another bug if you think that check should be there.