B2G Wifi: Fix wifi scanning on ICS

RESOLVED FIXED

Status

()

Core
Hardware Abstraction Layer (HAL)
--
critical
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: vchang, Assigned: mrbkap)

Tracking

Trunk
ARM
Gonk (Firefox OS)
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(blocking-basecamp:+)

Details

(Whiteboard: )

Attachments

(3 attachments, 2 obsolete attachments)

Created attachment 641009 [details] [diff] [review]
WIP

Wifi scanning on ICS is broken for Otoro devices.
Attachment #641009 - Flags: feedback?
(Reporter)

Comment 1

5 years ago
Created attachment 641014 [details] [diff] [review]
WIP
Attachment #641009 - Attachment is obsolete: true
Attachment #641009 - Flags: feedback?
Attachment #641014 - Flags: feedback?(mrbkap)
(Reporter)

Comment 2

5 years ago
Created attachment 641015 [details]
wpa_supplicant.conf

replaced /data/misc/wifi/wpa_supplicant.conf

Comment 3

5 years ago
We're currently blocked on testing due to this.  Here's the related gaia issue:
https://github.com/mozilla-b2g/gaia/issues/2361 - [settings] Wifi scans but does not present list of SSIDs
(Assignee)

Comment 4

5 years ago
Comment on attachment 641014 [details] [diff] [review]
WIP

This is the right approach. I have a cleaned-up patch as well.
Attachment #641014 - Flags: feedback?(mrbkap)
(Assignee)

Comment 5

5 years ago
Created attachment 641633 [details] [diff] [review]
Cleaner patch
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #641633 - Flags: review?(mwu)

Updated

5 years ago
Attachment #641633 - Flags: review?(mwu) → review+
(Assignee)

Comment 6

5 years ago
Comment on attachment 641633 [details] [diff] [review]
Cleaner patch

https://hg.mozilla.org/mozilla-central/rev/32c911bc2579
Attachment #641633 - Flags: checkin+
(Assignee)

Comment 7

5 years ago
Created attachment 641689 [details] [diff] [review]
Followup

mwu, I hope you don't mind reviewing this... basically this patch lets us not do the active/passive scanning stuff if the driver doesn't support it.
Attachment #641014 - Attachment is obsolete: true
Attachment #641689 - Flags: review?(mwu)

Comment 8

5 years ago
Comment on attachment 641689 [details] [diff] [review]
Followup

Not true - passive scans are fully supported with a nl80211 driver. wpa_supplicant just isn't exposing an interface to do it, and why should it? An active scan is what you want 98% of the time. WifiWorker.js probably shouldn't care about scan modes at all.

Comment 9

5 years ago
flagging blocking-basecamp
blocking-basecamp: --- → ?
blocking-basecamp: ? → +
This is still reproducible on a daily otoro build of 7-17-2012.   

REpro:
1) load settings > wifi
2) uncheck the wifi checkbox  (assuming you had networks found before)
3) recheck the wifi checkbox
4) Verify no networks are ever scanned or found again.
blocking-basecamp: + → ?

Comment 11

5 years ago
(In reply to Tony Chung [:tchung] from comment #10)
> This is still reproducible on a daily otoro build of 7-17-2012.   
> 
> REpro:
> 1) load settings > wifi
> 2) uncheck the wifi checkbox  (assuming you had networks found before)
> 3) recheck the wifi checkbox
> 4) Verify no networks are ever scanned or found again.

That is a different issue.
Tony, don't be a flag-clearer! ;)
blocking-basecamp: ? → +
Whiteboard:

Updated

5 years ago
Depends on: 774876
(In reply to Michael Wu [:mwu] from comment #11)
> (In reply to Tony Chung [:tchung] from comment #10)
> > This is still reproducible on a daily otoro build of 7-17-2012.   
> > 
> > REpro:
> > 1) load settings > wifi
> > 2) uncheck the wifi checkbox  (assuming you had networks found before)
> > 3) recheck the wifi checkbox
> > 4) Verify no networks are ever scanned or found again.
> 
> That is a different issue.

okay, i filed https://bugzilla.mozilla.org/show_bug.cgi?id=774876 to track this.

Updated

5 years ago
Blocks: 717123
Does this one look like a duplicate issue by Bug 782020 I just fired?

Updated

5 years ago
Attachment #641689 - Flags: review?(mwu)

Comment 15

5 years ago
Resolving this bug since the main issue is already fixed. I don't think we really need the follow up so I've cleared review, but we can do that in another bug if you think that check should be there.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.