Closed Bug 772801 Opened 7 years ago Closed 7 years ago

B2G Wifi: Fix wifi scanning on ICS

Categories

(Core :: Hardware Abstraction Layer (HAL), defect, critical)

ARM
Gonk (Firefox OS)
defect
Not set
critical

Tracking

()

RESOLVED FIXED
blocking-basecamp +

People

(Reporter: vchang, Assigned: mrbkap)

References

Details

(Whiteboard: )

Attachments

(3 files, 2 obsolete files)

Attached patch WIP (obsolete) — Splinter Review
Wifi scanning on ICS is broken for Otoro devices.
Attachment #641009 - Flags: feedback?
Attached patch WIP (obsolete) — Splinter Review
Attachment #641009 - Attachment is obsolete: true
Attachment #641009 - Flags: feedback?
Attachment #641014 - Flags: feedback?(mrbkap)
Attached file wpa_supplicant.conf
replaced /data/misc/wifi/wpa_supplicant.conf
We're currently blocked on testing due to this.  Here's the related gaia issue:
https://github.com/mozilla-b2g/gaia/issues/2361 - [settings] Wifi scans but does not present list of SSIDs
Comment on attachment 641014 [details] [diff] [review]
WIP

This is the right approach. I have a cleaned-up patch as well.
Attachment #641014 - Flags: feedback?(mrbkap)
Attached patch Cleaner patchSplinter Review
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #641633 - Flags: review?(mwu)
Attachment #641633 - Flags: review?(mwu) → review+
Attached patch FollowupSplinter Review
mwu, I hope you don't mind reviewing this... basically this patch lets us not do the active/passive scanning stuff if the driver doesn't support it.
Attachment #641014 - Attachment is obsolete: true
Attachment #641689 - Flags: review?(mwu)
Comment on attachment 641689 [details] [diff] [review]
Followup

Not true - passive scans are fully supported with a nl80211 driver. wpa_supplicant just isn't exposing an interface to do it, and why should it? An active scan is what you want 98% of the time. WifiWorker.js probably shouldn't care about scan modes at all.
flagging blocking-basecamp
blocking-basecamp: --- → ?
blocking-basecamp: ? → +
This is still reproducible on a daily otoro build of 7-17-2012.   

REpro:
1) load settings > wifi
2) uncheck the wifi checkbox  (assuming you had networks found before)
3) recheck the wifi checkbox
4) Verify no networks are ever scanned or found again.
blocking-basecamp: + → ?
(In reply to Tony Chung [:tchung] from comment #10)
> This is still reproducible on a daily otoro build of 7-17-2012.   
> 
> REpro:
> 1) load settings > wifi
> 2) uncheck the wifi checkbox  (assuming you had networks found before)
> 3) recheck the wifi checkbox
> 4) Verify no networks are ever scanned or found again.

That is a different issue.
Tony, don't be a flag-clearer! ;)
blocking-basecamp: ? → +
Whiteboard:
Depends on: 774876
(In reply to Michael Wu [:mwu] from comment #11)
> (In reply to Tony Chung [:tchung] from comment #10)
> > This is still reproducible on a daily otoro build of 7-17-2012.   
> > 
> > REpro:
> > 1) load settings > wifi
> > 2) uncheck the wifi checkbox  (assuming you had networks found before)
> > 3) recheck the wifi checkbox
> > 4) Verify no networks are ever scanned or found again.
> 
> That is a different issue.

okay, i filed https://bugzilla.mozilla.org/show_bug.cgi?id=774876 to track this.
Blocks: b2g-wifi
Does this one look like a duplicate issue by Bug 782020 I just fired?
Attachment #641689 - Flags: review?(mwu)
Resolving this bug since the main issue is already fixed. I don't think we really need the follow up so I've cleared review, but we can do that in another bug if you think that check should be there.
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.