Closed Bug 772830 Opened 12 years ago Closed 9 years ago

IonMonkey: Regalloc can assign the same register to multiple operands with useRegisterAtStart

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: jandem, Assigned: jandem)

References

(Blocks 1 open bug)

Details

(Whiteboard: [ion:t][leave open])

Attachments

(2 files)

Patch + hacks
8.15 KB, patch
Details | Diff | Splinter Review
Assert for now
3.91 KB, patch
dvander
: review+
Details | Diff | Splinter Review 
      No description provided.
Attached patch Patch + hacks — — Splinter Review 
Christian, as we discussed on IRC, can you fuzz this patch for a while on IonMonkey revision bf456ba39108 (later revisions are orange)? x86-only, I added some (temporary) hacks to exercise the code better but these changes break x64.
Attachment #641041 - Flags: feedback?(choller)
What's the current state of this bug, does it still need fuzzing? If so, can we get a patch rebased for m-c?
Attachment #641041 - Flags: feedback?(choller)
Attached patch Assert for now — — Splinter Review 
Unfortunately I don't have the time to look into this atm. To support this case we have to review all places where we split intervals etc. For now I think the right thing to do is restrict its use so that it doesn't bite people in the meantime.
Attachment #682398 - Flags: review?(dvander)
Attachment #682398 - Flags: review?(dvander) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/14be32aa7408
Whiteboard: [ion:t] → [ion:t][leave open]
LSRA is now disabled by default (and will be removed soon) so we can close this.
Status: ASSIGNED → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: