772855 - Log exception stack traces when logging errors

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: Log stack traces

We have a lot of code of the form:

catch (Exception e) {
  Log.e(LOGTAG, "some exception was thrown: " + e);
}

This just prints out the description of the exception which may or may not be very useful. It is better to do this instead:

catch (Exception e) {
  Log.e(LOGTAG, "some exception was thrown", e);
}

which will also print the stack trace of the exception.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Comment on attachment 641058 [details] [diff] [review]
Log stack traces

Moving review since mfinkle is on PTO.

Comment 2

[Chris Peterson [:cpeterson]]

Comment on attachment 641058 [details] [diff] [review]
Log stack traces

Review of attachment 641058 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM \o/

I feel we catch-and-ignore too many exceptions. This patch to log the exception stack traces is a good step in the right direction.

btw, this design anti-pattern of catching too many exceptions is apparently known as "Pokémon exception handling" because "You Gotta Catch 'Em All!" :)

Comment 3

[Kartikaya Gupta (email:[e-mail])]

(In reply to Chris Peterson (:cpeterson) from comment #2)
> btw, this design anti-pattern of catching too many exceptions is apparently
> known as "Pokémon exception handling" because "You Gotta Catch 'Em All!" :)

Lol, first time I'm hearing of that. Makes perfect sense :)

Landed on inbound:
https://hg.mozilla.org/integration/mozilla-inbound/rev/3f8e838c255a

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3f8e838c255a