772890 - GfxInfoThread can throw an ArrayIndexOutOfBoundsException

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Toolbar, defect)

Description

[Kartikaya Gupta (email:[e-mail])]

Attachment: (1/2) Update package for GfxInfoThread

I saw an exception being thrown from GfxInfoThread because the number of configs was zero. Also while fixing that I noticed that GfxInfoThread was in the gfx/ folder but the package was org.mozilla.gecko - so I updated that as well to be org.mozilla.gecko.gfx.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

Attachment: (2/2) Guard against ArrayIndexOutOfBoundsException

Comment 2

[Benoit Jacob [:bjacob] (mostly away)]

Comment on attachment 641068 [details] [diff] [review]
(2/2) Guard against ArrayIndexOutOfBoundsException

Review of attachment 641068 [details] [diff] [review]:
-----------------------------------------------------------------

r=me with this change:

::: mobile/android/base/gfx/GfxInfoThread.java
@@ +92,5 @@
>          int numConfigs = returnedNumberOfConfigs[0];
> +        if (numConfigs == 0) {
> +            eglError(egl, "eglChooseConfig returned zero configs");
> +            return;
> +        }

Use error() instead of eglError(), as technically this isn't an EGL error, and if an EGL error happened, the previous if() should have caught it.

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

I would be interested in knowing what Android system gave you zero configs? Is it a system that we want to try to support?

Comment 4

[Kartikaya Gupta (email:[e-mail])]

This is a Motorola Backflip device with an ARMv6 processor. Even with this patch Firefox isn't starting up properly on the device (bug 772886) so I don't yet know if this is a device that can be supported fully. It would be nice to though :)

Comment 5

[Kartikaya Gupta (email:[e-mail])]

Landed on inbound with the comment addressed:

https://hg.mozilla.org/integration/mozilla-inbound/rev/ebfbd27fe7b5
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb59a53bda40

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/ebfbd27fe7b5
https://hg.mozilla.org/mozilla-central/rev/bb59a53bda40