Last Comment Bug 772901 - IonMonkey: Assertion failure: false (Bad SSA value), at ../jsanalyze.h:1069
: IonMonkey: Assertion failure: false (Bad SSA value), at ../jsanalyze.h:1069
: assertion, testcase
Product: Core
Classification: Components
Component: JavaScript Engine (show other bugs)
: Other Branch
: x86_64 Linux
-- major (vote)
: ---
Assigned To: David Anderson [:dvander]
: general
: Jason Orendorff [:jorendorff]
Depends on:
Blocks: langfuzz IonFuzz
  Show dependency treegraph
Reported: 2012-07-11 09:33 PDT by Christian Holler (:decoder)
Modified: 2013-01-14 08:17 PST (History)
7 users (show)
choller: in‑testsuite+
See Also:
Crash Signature:
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---

fix (5.34 KB, patch)
2012-07-11 18:01 PDT, David Anderson [:dvander]
sstangl: review+
Details | Diff | Splinter Review

Description User image Christian Holler (:decoder) 2012-07-11 09:33:29 PDT
The following testcase asserts on ionmonkey revision 3ff7d89ec13d (run with --ion -n -m --ion-eager):

function f(x) {
    delete ((x)++);
    arguments[0] !== undefined;
f(1, x = [f.ArrayBuffer,unwatch.Int32Array], this, this, this) ;
Comment 1 User image David Anderson [:dvander] 2012-07-11 18:01:02 PDT
Created attachment 641294 [details] [diff] [review]

status update on whether LOCALINC will plague me in this JIT too: yes
Comment 2 User image Sean Stangl [:sstangl] 2012-07-12 11:57:22 PDT
Comment on attachment 641294 [details] [diff] [review]

Review of attachment 641294 [details] [diff] [review]:

::: js/src/ion/TypeOracle.cpp
@@ +133,5 @@
>      }
> +    BinaryTypes b;
> +    b.lhsTypes = types;
> +    b.rhsTypes = NULL;

This is strange, but works since the value is unused in jsop_incslot. Since this isn't a binary operation anyway, would it just be possible to use pushedTypeSet()? JM does this in its jsop_localinc().
Comment 3 User image David Anderson [:dvander] 2012-07-12 14:24:57 PDT
Actually yeah I think returning UnaryTypes would make more sense, but MAdd::infer() only takes a BinaryTypes. I'll leave it alone for now...
Comment 4 User image Christian Holler (:decoder) 2013-01-14 08:17:00 PST
A testcase for this bug was automatically identified at js/src/jit-test/tests/ion/bug772901.js.

Note You need to log in before you can comment on or make changes to this bug.