772966 - force XBL parameter names to be non-zero

Status: RESOLVED FIXED

(Core :: XBL, enhancement)

Description

[:Benjamin Peterson]

Otherwise XBL can pass empty parameter names through the JS API, which is not exactly supported.

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Can JSAPI handle cases when param name contains whitespaces?

Comment 2

[:Benjamin Peterson]

(In reply to Olli Pettay [:smaug] from comment #1)
> Can JSAPI handle cases when param name contains whitespaces?

We don't check if anything is a valid identifier. If it contains whitespace, nothing will probably go wrong, but that's useless, right? You can use JS_IsIdentifier to do this check.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: bypass empty params

Comment 4

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 641200 [details] [diff] [review]
bypass empty params

Review of attachment 641200 [details] [diff] [review]:
-----------------------------------------------------------------

::: content/xbl/src/nsXBLProtoImplMethod.cpp
@@ +57,5 @@
>  {
>    NS_PRECONDITION(!IsCompiled(),
>                    "Must not be compiled when accessing uncompiled method");
>  
> +  NS_ENSURE_TRUE(!aText.IsEmpty(), );

Empty macro arguments cause build warnings :(

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Really? We have those in many places.
But I can change that to
if (aText.IsEmpty()) {
  NS_WARNING("Empty name attribute in xbl:parameter!");
  return;
}

Comment 6

[Olli Pettay [:smaug][[e-mail]]]

Attachment: patch

Comment 7

[Olli Pettay [:smaug][[e-mail]]]

https://hg.mozilla.org/mozilla-central/rev/588424024294