772968 - Specify a different APP_ID for fennec webapp runtime

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Web Apps (PWAs), defect, P1)

Description

[Pedro Alves]

Currently webapp runtime on fennec is indistinguishable from fennec, as it uses the same APP_ID.



Would be useful to give it a different one. Desktop webapp rt uses '[e-mail]'. Something like '[e-mail]' would be nice (or whatever unique app_id)

Comment 1

[Myk Melez [:myk] [@mykmelez]]

(Minor correction: the desktop runtime actually uses the app ID [e-mail].)

cc:ing some of the Fennec folks who are working on the Android runtime.

Note that we discussed whether or not to distinguish runtime reports from Firefox reports on desktop, and we ultimately decided to distinguish them, even if some (perhaps most) will have identical root causes, because others will not, and the relative frequencies of even identical crashes will vary because of the different usage patterns of apps vs. the web as a whole (so topcrashes will differ).

Changing our minds about that is relatively easy, provided the runtime has a different app ID, because we can reprocess reports and munge products together (or vice-versa).  But the runtime does need to have a different app ID for us to have the option to distinguish its reports, hence this bug.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

As long as Fennec _is_ the webapp runtime on Android, we can't change the core APP ID.

We might be able to play with the URL sent to the blocklist (or whatever URL metrics uses) to substitute a different APP ID.

Comment 3

[Pedro Alves]

From the metrics end, changing the app_id to something unique or changing the blocklist ping to something like: 

https://addons.mozilla.org/blocklist/3/<insert_unique_stuff_here>/%APP_VERSION%/%PRODUCT%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/%PING_COUNT%/%TOTAL_PING_COUNT%/%DAYS_SINCE_LAST_PING%/

would be exactly the same


(is url is a modification of the one extracted from firefox desktop: https://addons.mozilla.org/blocklist/3/%APP_ID%/%APP_VERSION%/%PRODUCT%/%BUILD_ID%/%BUILD_TARGET%/%LOCALE%/%CHANNEL%/%OS_VERSION%/%DISTRIBUTION%/%DISTRIBUTION_VERSION%/%PING_COUNT%/%TOTAL_PING_COUNT%/%DAYS_SINCE_LAST_PING%/ , I'm assuming fennec is the same)

Comment 4

[Wesley Johnston (:wesj)]

Attachment: Patch

Sending this review to mfinkle because I want to make sure he's ok with it.

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 645596 [details] [diff] [review]
Patch

This method should work OK. I worry that "mobile" is too general. This is the webapprt for Android only. Other mobile platforms will have different runtimes.

Maybe I am over thinking things.

nit: '[e-mail]' -> "[e-mail]"

* add the '-'
* 'com" -> 'org'
* use double quotes

Comment 6

[Robert Kaiser]

That would mean that we'd also need to add both an ADI mechanism for the mobile webapp runtime in separate, just as we did for desktop, and that we'd also need to add it as a separate product in Socorro for monitoring crashes.

Comment 7

[Wesley Johnston (:wesj)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/9d1e28ff0bfa

Comment 8

[Wesley Johnston (:wesj)]

Comment on attachment 645596 [details] [diff] [review]
Patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): No regression
User impact if declined: none
Testing completed (on m-c, etc.): landed on mc today 8/3
Risk to taking this patch (and alternatives if risky): very low risk. Just changes a pref on webapps. needed to push webapps in 16
String or UUID changes made by this patch: None.

Comment 9

[[:jberkus] Josh Berkus]

So has this been changed in crash reporting?

And if so, what AppID is it reporting?

Daniel, will metrics have any ADU for Fennec WebRT?

Comment 11

[Wesley Johnston (:wesj)]

I'm not familiar with the crash reporter code. An mxr search showed %APP_ID% only being used for addon updates (addons are disabled in webapps) and in the addon blocklist. I'll have to dig more to know for sure that one of them is being used for crash reporting somehow (unless you can point me to some code?)

Comment 12

[Daniel Einspanjer [:dre] [:deinspanjer]]

s/ADU/ADI.  ADI is Mozilla's measure of Active Daily Installs.  Currently, this measurement is derived from the add-on blocklist check requests that come in to addons.mozilla.org.  The Crash Stats team (Socorro) uses the ADI to calculate the ratio of crash reports to install-base.

If the Fennec WebappRT doesn't make a blocklist check, we will not have any visibility into the number of active daily installs for it.

If this is the case, we need to escalate this issue and figure out quickly how to fix or work around it.

Comment 13

[Robert Kaiser]

(In reply to Wesley Johnston (:wesj) from comment #11)
> I'm not familiar with the crash reporter code.

Bug 745980 apparently implemented crash reporting for the desktop WebRT, I guess that code can help.

Comment 14

[Wesley Johnston (:wesj)]

(In reply to Daniel Einspanjer :dre [:deinspanjer] from comment #12)
> If the Fennec WebappRT doesn't make a blocklist check, we will not have any
> visibility into the number of active daily installs for it.

I need to double check that disabling addons doesn't disable the blocklist check, but we're currently doing the same thing that desktop does, so I imagine we're fine.

Comment 15

[Pedro Alves]

I can confirm that we are getting the correct information from desktop

Comment 16

[mroldan]

We gave the name 'WebappRuntime' to the desktop webapprt ('[e-mail]')

So we're going to give the name 'WebappRuntime Mobile' to this new one ('[e-mail]') unless someone has a better suggestion.

thanks,

Comment 17

[Pedro Alves]

Remove the whitespace, please. It's easier for the socorro team

Comment 18

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/9d1e28ff0bfa

Comment 19

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 645596 [details] [diff] [review]
Patch

Just for WebRT so shouldn't affect Fennec itself - approving for Aurora.

Comment 20

[Wesley Johnston (:wesj)]

pushed
https://hg.mozilla.org/releases/mozilla-aurora/rev/5ea8570c5955